Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace Rector\Tests\Naming\Rector\ClassMethod\RenameParamToMatchTypeRector\Fixture;

use Rector\Tests\Naming\Rector\ClassMethod\RenameParamToMatchTypeRector\Source\EliteManager;
use Rector\Tests\Naming\Rector\ClassMethod\RenameParamToMatchTypeRector\Source\vendor\SomeVendorWithParam;

class SkipOverrideVendorParam extends SomeVendorWithParam
{
public function run(EliteManager $eventManager)
{
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
<?php

declare(strict_types=1);

namespace Rector\Tests\Naming\Rector\ClassMethod\RenameParamToMatchTypeRector\Source\vendor;

use Rector\Tests\Naming\Rector\ClassMethod\RenameParamToMatchTypeRector\Source\EliteManager;

final class SomeVendorWithParam
{
public function run(EliteManager $eventManager)
{
}
}
47 changes: 46 additions & 1 deletion rules/Naming/Rector/ClassMethod/RenameParamToMatchTypeRector.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,16 @@
use PhpParser\Node\Param;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Function_;
use PHPStan\Reflection\ClassReflection;
use Rector\Naming\ExpectedNameResolver\MatchParamTypeExpectedNameResolver;
use Rector\Naming\Guard\BreakingVariableRenameGuard;
use Rector\Naming\Naming\ExpectedNameResolver;
use Rector\Naming\ParamRenamer\ParamRenamer;
use Rector\Naming\ValueObject\ParamRename;
use Rector\Naming\ValueObjectFactory\ParamRenameFactory;
use Rector\Rector\AbstractRector;
use Rector\Reflection\ReflectionResolver;
use Rector\Skipper\FileSystem\PathNormalizer;
use Rector\ValueObject\MethodName;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
Expand All @@ -33,7 +36,8 @@ public function __construct(
private readonly ExpectedNameResolver $expectedNameResolver,
private readonly MatchParamTypeExpectedNameResolver $matchParamTypeExpectedNameResolver,
private readonly ParamRenameFactory $paramRenameFactory,
private readonly ParamRenamer $paramRenamer
private readonly ParamRenamer $paramRenamer,
private readonly ReflectionResolver $reflectionResolver,
) {
}

Expand Down Expand Up @@ -85,6 +89,10 @@ public function refactor(Node $node): ?Node
continue;
}

if ($node instanceof ClassMethod && $this->shouldSkipClassMethodFromVendor($node)) {
return null;
}

$expectedName = $this->expectedNameResolver->resolveForParamIfNotYet($param);
if ($expectedName === null) {
continue;
Expand Down Expand Up @@ -115,6 +123,43 @@ public function refactor(Node $node): ?Node
return $node;
}

private function shouldSkipClassMethodFromVendor(ClassMethod $classMethod): bool
{
if ($classMethod->isPrivate()) {
return false;
}

$classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);
if (! $classReflection instanceof ClassReflection) {
return false;
}

$ancestors = array_filter(
$classReflection->getAncestors(),
fn (ClassReflection $ancestorClassReflection): bool =>
$classReflection->getName() !== $ancestorClassReflection->getName()
);

$methodName = $this->getName($classMethod);
foreach ($ancestors as $ancestor) {
// internal
if ($ancestor->getFileName() === null) {
continue;
}

if (! $ancestor->hasNativeMethod($methodName)) {
continue;
}

$path = PathNormalizer::normalize($ancestor->getFileName());
if (str_contains($path, '/vendor/')) {
return true;
}
}

return false;
}

private function shouldSkipParam(
Param $param,
string $expectedName,
Expand Down
Loading