Skip to content
/ rector-src Public

[TypeDeclaration] Clean up type based on docblock check on AddMethodCallBasedStrictParamTypeRector #7177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Aug 26, 2025
Merged

[TypeDeclaration] Clean up type based on docblock check on AddMethodCallBasedStrictParamTypeRector #7177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0ec489
[TypeDeclaration] Clean up type based on doc check on AddMethodCallBa…
samsonasik Aug 26, 2025
d5410ea
[ci-review] Rector Rectify
actions-user Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,14 @@
use PHPStan\Type\UnionType;
use Rector\NodeTypeResolver\NodeTypeResolver;
use Rector\NodeTypeResolver\PHPStan\Type\TypeFactory;
use Rector\NodeTypeResolver\TypeComparator\TypeComparator;
use Rector\StaticTypeMapper\Resolver\ClassNameFromObjectTypeResolver;

final readonly class CallTypesResolver
{
public function __construct(
private NodeTypeResolver $nodeTypeResolver,
private TypeFactory $typeFactory,
private ReflectionProvider $reflectionProvider,
private TypeComparator $typeComparator
private ReflectionProvider $reflectionProvider
) {
}

Expand Down Expand Up @@ -69,11 +67,6 @@ private function resolveStrictArgValueType(Arg $arg): Type
return new MixedType();
}

$type = $this->nodeTypeResolver->getType($arg->value);
if (! $type->equals($argValueType) && $this->typeComparator->isSubtype($type, $argValueType)) {
return $type;
}

return $argValueType;
}

Expand Down
Loading