[TypeDeclaration] Skip Valid type from return doc and typed param on AddMethodCallBasedStrictParamTypeRector#7172
Merged
samsonasik merged 2 commits intomainfrom Aug 24, 2025
Merged
Conversation
…AddMethodCallBasedStrictParamTypeRector
Member
Author
|
Fixed 🎉 /cc @calebdw |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Member
Author
|
@calebdw After looking at answer at PHPStan issue it seems original change expected, as While it seems make sense enforced by doc vs instanceof check, I will look if it cause more harm on our projects, if no, this is a current win-win solution, otherwise, I am just going to revert ;) |
Member
Author
|
@calebdw I created new PR to skip when param already typed: |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9324