[PHP 8.5] Convert @deprecated to #[\Deprecated] on constants#7155
Merged
samsonasik merged 1 commit intorectorphp:mainfrom Aug 20, 2025
Merged
[PHP 8.5] Convert @deprecated to #[\Deprecated] on constants#7155samsonasik merged 1 commit intorectorphp:mainfrom
@deprecated to #[\Deprecated] on constants#7155samsonasik merged 1 commit intorectorphp:mainfrom
Conversation
DanielEScherzer
force-pushed
the
deprecated-constants
branch
from
c46b62b to
251b70b
Compare
samsonasik
reviewed
Aug 20, 2025
rules/Php85/Rector/Const_/DeprecatedAnnotationToDeprecatedAttributeRector.php
Outdated
Show resolved
Hide resolved
DanielEScherzer
force-pushed
the
deprecated-constants
branch
from
251b70b to
3ba04e4
Compare
samsonasik
reviewed
Aug 20, 2025
src/PhpAttribute/DeprecatedAnnotationToDeprecatedAttributeConverter.php
Outdated
Show resolved
Hide resolved
Based on the PHP 8.4 rule from rectorphp#6923, logic was moved to a new `DeprecatedAnnotationToDeprecatedAttributeConverter` service to avoid duplication.
DanielEScherzer
force-pushed
the
deprecated-constants
branch
from
3ba04e4 to
650867f
Compare
samsonasik
approved these changes
Aug 20, 2025
Member
|
Looks good, thank you @DanielEScherzer |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the PHP 8.4 rule from #6923, logic was moved to a new
DeprecatedAnnotationToDeprecatedAttributeConverterservice to avoid duplication.