feat: Add AddReturnDocblockForScalarArrayFromAssignsRector#7151
Merged
TomasVotruba merged 3 commits intorectorphp:mainfrom Aug 22, 2025
Merged
feat: Add AddReturnDocblockForScalarArrayFromAssignsRector#7151TomasVotruba merged 3 commits intorectorphp:mainfrom
TomasVotruba merged 3 commits intorectorphp:mainfrom
Conversation
…ain of the types inside the array (eg. when they were initialised and returned within the same function)
samsonasik
reviewed
Aug 18, 2025
rules/TypeDeclaration/Rector/ClassMethod/AddReturnDocblockForScalarArrayFromAssignsRector.php
Outdated
Show resolved
Hide resolved
…calarArrayFromAssignsRector.php Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Member
|
Thank you for such a quick kick off. This might require few iterations, so lets ship it and test it in the wild 🚀 |
Member
|
@TomasVotruba should we try add to type declaration set? |
Member
|
@samsonasik Yes, I've missed it. |
Member
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a more specific return docblock for scalar lists when we are certain of the types inside the array (eg. when they were initialised and returned within the same function)
Fixes rectorphp/rector#9312