[ci] check extra after part in fixture, that show no change + check no PHP files in /Fixture dirs #7134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-before-after-ci
branch
2 times, most recently
from
6e24025 to
835f6ff
Compare
TomasVotruba
commented
Aug 11, 2025
|
|
||
| - | ||
| name: 'Check before/after test fixture on no-changes' | ||
| run: php bin/check-before-after-same-fixtures.php |
Member
Author
There was a problem hiding this comment.
@samsonasik This might help with code reviews 👍
Member
There was a problem hiding this comment.
@TomasVotruba the files seems commited on scoped vendor, should it be removed before scoped?
rectorphp/rector@d2d451e#diff-6a943cc1e536167118f5fb8160e164027ae139c4986d1e324a1faabbd1f39b36
Member
Author
There was a problem hiding this comment.
👍 Indeed, should be removed
Member
There was a problem hiding this comment.
Ok, I removed at PR:
TomasVotruba
force-pushed
the
tv-before-after-ci
branch
5 times, most recently
from
60a6093 to
be61386
Compare
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-before-after-ci
branch
from
be61386 to
cceab77
Compare
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.