Skip to content
/ rector-src Public

[DeadCode] Skip with get_defined_vars() on RemoveUnusedPrivateMethodParameterRector #7105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Aug 5, 2025
Merged

[DeadCode] Skip with get_defined_vars() on RemoveUnusedPrivateMethodParameterRector #7105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3097c95
[DeadCode] Skip with get_defined_vars() on RemoveUnusedPrivateMethodP…
samsonasik Aug 5, 2025
7309db0
[DeadCode] Skip with get_defined_vars() on RemoveUnusedPrivateMethodP…
samsonasik Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...lassMethod/RemoveUnusedPrivateMethodParameterRector/Fixture/skip_get_defined_vars.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?php

namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedPrivateMethodParameterRector\Fixture;

final class SkipGetDefinedVars
{
private function example($value): array
{
return get_defined_vars();
}
}
2 changes: 1 addition & 1 deletion src/NodeAnalyzer/ParamAnalyzer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
/**
* @var string[]
*/
private const VARIADIC_FUNCTION_NAMES = ['func_get_arg', 'func_get_args', 'func_num_args'];
private const VARIADIC_FUNCTION_NAMES = ['func_get_arg', 'func_get_args', 'func_num_args', 'get_defined_vars'];

public function __construct(
private NodeComparator $nodeComparator,
Expand Down
Loading