Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?php

namespace Rector\Tests\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector\Fixture;

class OnArg extends TestCase
{
private CarbonImmutable $now;

#[\Override]
protected function setUp(): void
{
parent::setUp();

CarbonImmutable::setTestNow(
$this->now = nowEagleTz(),
);
}
}

?>
-----
<?php

namespace Rector\Tests\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector\Fixture;

class OnArg extends TestCase
{
#[\Override]
protected function setUp(): void
{
parent::setUp();

CarbonImmutable::setTestNow(
nowEagleTz(),
);
}
}

?>
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace Rector\DeadCode\Rector\Property;

use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\Expression;
Expand Down Expand Up @@ -155,8 +156,16 @@ private function shouldSkipClass(Class_ $class): bool

private function removePropertyAssigns(Class_ $class, string $propertyName): void
{
$this->traverseNodesWithCallable($class, function (Node $node) use ($class, $propertyName): null|int|Return_ {
$this->traverseNodesWithCallable($class, function (Node $node) use ($class, $propertyName): null|int|Return_|Arg {
if (! $node instanceof Expression && ! $node instanceof Return_) {
if ($node instanceof Arg && $node->value instanceof Assign) {
$assign = $node->value;
if ($this->propertyFetchFinder->isLocalPropertyFetchByName($assign->var, $class, $propertyName)) {
$node->value = $assign->expr;
return $node;
}
}

return null;
}

Expand Down