perf: break out of loop instead of continuing

[calebdw]

This improves performance by avoiding unnecessary iterations when the level is already reached.

[TomasVotruba]

Nice one 👍 Thank you

[calebdw]

@TomasVotruba, while debugging, I noticed that this loop was being executed multiple times while rector was running---I would have only expected this loop to be executed once at the start of the analysis. Is there a reason for this or is this an inefficiency / bug?

I wanted some insight into what the latest rule was as I'm increasing the php levels so I added a dump call right before the break:

[TomasVotruba]

Most like it's parallel run, where each thread has isolated context.

[calebdw]

I am running parallel so that makes sense---but I would still only expect the number of threads that are running (~16).

Is rector rebuilt during the analysis?

[TomasVotruba]

Depends. The number of cores doesn't always equal number of threads.

There is one process that invokes child process.
That's usually with explicit list of X files. Once these X files are finished, it returns json result and dies.

This happens untill all files are done. That means there are 16 threads, but they run Y processes over and over, until all files are done. Y can be huge :) at least that's how I understand it.

This might help:

• https://phpstan.org/config-reference#parallel-processing
• https://getrector.com/documentation/troubleshooting-parallel#content-configure-parallel
• https://reactphp.org/

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.