Skip to content
/ rector-src Public

[AutoImport] Handle auto import short name on global namespace #7086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Jul 23, 2025
Merged

[AutoImport] Handle auto import short name on global namespace #7086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fd7dc5
[AutoImport] Handle auto import short name on global namespace
samsonasik Jul 23, 2025
1a7f125
Fix
samsonasik Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions ...gStyle/Rector/Namespace_/ImportFullyQualifiedNamesRector/Fixture/global_namespace.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?php

namespace
{
class GlobalNamespace
{
public function create()
{
return new \DateTime();
}
}
}

?>
-----
<?php

namespace
{
class GlobalNamespace
{
public function create()
{
return new DateTime();
}
}
}

?>
6 changes: 6 additions & 0 deletions rules/CodingStyle/Application/UseImportsAdder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,12 @@ private function createUses(
continue;
}

if ($namespaceName === null
&& $importType instanceof FullyQualifiedObjectType
&& substr_count(ltrim($importType->getClassName(), '\\'), '\\') === 0) {
continue;
}

// already imported in previous cycle
$newUses[] = $importType->getUseNode($type);
}
Expand Down