[StrContainsRector] also replace multibyte functions fro strpos and strstr #6905
Conversation
JohJohan
force-pushed
the
StrContainsRector
branch
from
6e37640 to
1cf6796
Compare
|
@samsonasik note i also check for |
...Rector/NotIdentical/StrContainsRector/Fixture/offset_variable_equal_multibyte_strpos.php.inc
Outdated
Show resolved
Hide resolved
JohJohan
force-pushed
the
StrContainsRector
branch
from
1cf6796 to
f34fb90
Compare
rules-tests/Php80/Rector/NotIdentical/StrContainsRector/Fixture/multibyte_offset_strpos.php.inc
Outdated
Show resolved
Hide resolved
JohJohan
force-pushed
the
StrContainsRector
branch
from
f34fb90 to
8f4f33c
Compare
JohJohan
force-pushed
the
StrContainsRector
branch
from
8f4f33c to
49db14d
Compare
| { | ||
| public function run() | ||
| { | ||
| $isMatch = str_contains(mb_substr('happy 😊 euro €', 1), 'a'); |
There was a problem hiding this comment.
I think we need specific fixture where using mb_substr is different compared to use normal substr if the position is match
There was a problem hiding this comment.
I think you mean this should differ from offset_strpos.php.inc right? I added a match for letter e and position 8 because the emoji will take more bytes than 1 so you would need the mb_ funct to do the correct match is that what you meant?
JohJohan
force-pushed
the
StrContainsRector
branch
from
49db14d to
700b026
Compare
JohJohan
force-pushed
the
StrContainsRector
branch
from
700b026 to
e33f105
Compare
|
@JohJohan I talked with @TomasVotruba today, and it seems it probably better to create new rule for it, but without register to which share same logic for both functionality, and add condition for different rule :) |
|
@JohJohan Friendly ping 👍 |
|
@TomasVotruba sorry for the late reply I'm busy last week's. I haven't forgotten this and will pick it up as soon as I can. |
|
handled at PR |
3 participants
No description provided.