DowngradeFinalPropertyPromotionRector

[arshidkv12]

No description provided.

[samsonasik]

use Node\Stmt\ClassMethod

[samsonasik]

use docblockUpdater instead, ensure existing doc when exists not removed, see example

rector-downgrade-php/rules/DowngradePhp81/Rector/Property/DowngradeReadonlyPropertyRector.php

Lines 131 to 142 in 8ab1dce

	private function addPhpDocTag(Property|Param $node): bool
	{
	$phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
	if ($phpDocInfo->hasByName(self::TAGNAME)) {
	return false;
	}
	$phpDocInfo->addPhpDocTagNode(new PhpDocTagNode('@' . self::TAGNAME, new GenericTagValueNode('')));
	$this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($node);
	return true;
	}

[samsonasik]

use ->isPromoted()

[samsonasik]

use VisibilityManipulator->hasVisibility() as well

https://github.com/rectorphp/rector-src/blob/c32b6305df1bf1a01f1a7e3d48dea5316619d505/rules/Privatization/NodeManipulator/VisibilityManipulator.php#L21

[arshidkv12]

 if(!$this->visibilityManipulator->hasVisibility($param, Visibility::PUBLIC)){
        continue;
    }

Correct ?

[samsonasik]

Visibility::FINAL

[samsonasik]

use VisibilityManipulator->makeNonFinal() usage, see

https://github.com/rectorphp/rector-src/blob/c32b6305df1bf1a01f1a7e3d48dea5316619d505/rules/Privatization/NodeManipulator/VisibilityManipulator.php#L69

[arshidkv12]

Ok

[arshidkv12]

The makeNonFinal method is accepting Class_|ClassMethod, not accepting param

[samsonasik]

It should add Param as well on rector-src then

[samsonasik]

Suggested change

	class Fixture
	class SkipFixtureReadonly

[samsonasik]

Probably consider implicit property promotion fixture as well:

class ImplicitFinalPropertyPromotion
{
-    public function __construct(final string $foo)
+    public function __construct(
+         /**
+           * @final
+           */
+         public string $foo
    )
    {
    }
}

https://3v4l.org/BXcO6/rfc#vgit.master

However, this probably a "bug" in php 8.5 which without explicit public, it can't be accessed even it should means a public, see the different:

• https://3v4l.org/TdZfV/rfc#vgit.master (explicit)
• https://3v4l.org/LMaT0/rfc#vgit.master (implicit)

[samsonasik]

Please add fixture I requested above #317 (review) and run rector and fix-cs

vendor/bin/rector && composer fix-cs

[arshidkv12]

Please check it.

[samsonasik]

Please add fixture for implicit public I requested above

#317 (review)

[samsonasik]

Thank you @arshidkv12 , I've added $hasChanged check flag to verify node is changed.

[samsonasik]

@arshidkv12 oh, this is .php file, and skipped from the scan, should be .php.inc, I was wondering why it was working ...

[samsonasik]

#324