[DowngradePhp81] Add @readonly doc on property promotion readonly #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I updated to use Before - public function __construct(public array $property)
+ public function __construct(/**
+ * @readonly
+ */
+ public array $property)After - public function __construct(public array $property)
+ public function __construct(
+ /**
+ * @readonly
+ */
+ public array $property
+ )
{
} |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) |
samsonasik
commented
Sep 8, 2025
|
|
||
| $this->visibilityManipulator->removeReadonly($node); | ||
| if ($hasChangedDoc) { | ||
| $node->setAttribute(AttributeKey::ORIGINAL_NODE, null); |
Member
Author
There was a problem hiding this comment.
I will check if this can be tweaked without re-print the whole ClassMethod.
Member
Author
There was a problem hiding this comment.
I am thinking reprint should not happen on whole class, less pretty, but should be safer. I will create PR for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://phpstan.org/r/7fe0ce63-8d29-4f53-b1c6-5a05c3d31b74
The
@readonlyflag will warn user when user want to change property of promotion.