[DowngradePhp74] Handle merge const on DowngradeArraySpreadStringKeyRector + DowngradeArraySpreadRector #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ector + DowngradeArraySpreadRector
samsonasik
force-pushed
the
handle-merge-const
branch
from
188c102 to
166904e
Compare
This reverts commit d2d205f.
Member
Author
|
Fixed 🎉 /cc @zonuexe going afk , I will do some testing on more usecase if possible and will merge and use in rector-src codebase downgrade when I back to pc again :) |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9291