Skip to content

Fix php 8.4 compatible code on BitwiseFlagCleaner #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 2 commits into from
Jan 27, 2025
Merged

Fix php 8.4 compatible code on BitwiseFlagCleaner #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a667cc7
Fix php 8.4 compatible code BitwiseFlagCleaner
samsonasik Jan 27, 2025
1025ff1
[ci-review] Rector Rectify
actions-user Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/DowngradePhp72/NodeManipulator/BitwiseFlagCleaner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public function __construct(
) {
}

public function cleanFuncCall(FuncCall $funcCall, BitwiseOr $bitwiseOr, string $flag, Expr $expr = null): void
public function cleanFuncCall(FuncCall $funcCall, BitwiseOr $bitwiseOr, string $flag, ?Expr $expr = null): void
{
if ($bitwiseOr->left instanceof BitwiseOr) {
/** @var BitwiseOr $leftLeft */
Expand Down
4 changes: 2 additions & 2 deletions src/PhpDocDecorator/PhpDocFromTypeDeclarationDecorator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public function __construct(

public function decorateReturn(ClassMethod|Function_|Closure|ArrowFunction $functionLike): void
{
if ($functionLike->returnType === null) {
if (! $functionLike->returnType instanceof Node) {
return;
}

Expand Down Expand Up @@ -159,7 +159,7 @@ public function decorateReturnWithSpecificType(
ClassMethod|Function_|Closure|ArrowFunction $functionLike,
Type $requireType
): bool {
if ($functionLike->returnType === null) {
if (! $functionLike->returnType instanceof Node) {
return false;
}

Expand Down
Loading