Fix for Match to Switch when inside binary operation

[peterfox]

Changes

• adds a new fixture for the switch to match statement rule in the downgrade to PHP 7.2 test
• adds changes to the DowngradeMatchToSwitchRector rule.

Why

Currently this rule breaks code where the match statement exists within a binary operation. For example:

public function run($value, $booleanFlag)
{
    return match (true) {
        $value === 2 => true,
        default => false,
    } && $booleanFlag;
}

would become

public function run($value, $booleanFlag)
{
    switch (true) {
        case $value === 2:
            return true;
        default:
            return false;
    }
}

This would cause conditions related to the return statement to be lost. This happened in the Rector Laravel project. For now I've just separated the match statement and the binary op, but it would be nice to fix this either way.

This change fixes that by allowing the rest of the return statement to be retained with the case's return statement.

public function run($value, $booleanFlag)
    {
        switch (true) {
            case $value === 2:
                return true && $booleanFlag;
            default:
                return false && $booleanFlag;
        }
    }

[TomasVotruba]

Looks good, thank you 👍

[samsonasik]

Let's give it a try, thank you @peterfox