Skip to content

Fix Pin PHP-Parser 4.10.0 test #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samsonasik wants to merge 4 commits into from
Closed

Fix Pin PHP-Parser 4.10.0 test #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10e38a2
Fix Pin PHP-Parser 4.10.0
samsonasik Oct 14, 2025
b24554c
Fix Pin PHP-Parser 4.10.0
samsonasik Oct 14, 2025
57f03b4
Fix namespace test
samsonasik Oct 14, 2025
99872fa
Fix namespace test
samsonasik Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/compat_tests.yaml.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
matrix:
actions:
-
name: 'Rector dev + PHPUnit 10'
run: composer require "phpunit/phpunit:10.*" "nikic/php-parser:4.*" -W
name: 'Rector dev + PHPUnit 8'
run: composer require "phpunit/phpunit:8.*" "nikic/php-parser:4.10.0" -W
php: 8.2
-
name: 'Rector dev + PHPUnit 11'
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Todo

* [x] add simple custom rule test
* [x] run with PHPUnit 10, 11, 12
* [x] run with PHPUnit 8, 11, 12
* [x] add PHPStan custom test too
* everything should pass
* add this to `rectorphp/rector-src` CI to verify everything works well :)
4 changes: 2 additions & 2 deletions tests/UsePHPParser4Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php

namespace Rector\RectorCompatTests\Tests\Rector\MakeClassFinalRector;
namespace Rector\RectorCompatTests\Tests;

use PHPUnit\Framework\TestCase;
use PHPUnit\Runner\Version;
Expand All @@ -10,7 +10,7 @@ final class UsePHPParser4Test extends TestCase
public function test(): void
{
if ((int) Version::id() >= 11) {
$this->markTestSkipped('Only for PHPUnit 11+');
$this->markTestSkipped('Only for PHPUnit < 11');
}

// this uses nikic/php-parser v4 parser
Expand Down
Loading