Bump rubocop from 0.86.0 to 0.91.1 #152

dependabot-preview · 2020-09-23T10:17:40Z

Bumps rubocop from 0.86.0 to 0.91.1.

Release notes

RuboCop 0.91

New features

New option --cache-root and support for the RUBOCOP_CACHE_ROOT environment variable. Both can be used to override the AllCops: CacheRootDirectory config, especially in a CI setting. (@sascha-wolf)

#8582: Add new Layout/BeginEndAlignment cop. (@koic)

#8699: Add new Lint/IdentityComparison cop. (@koic)

Add new Lint/UselessTimes cop. (@dvandersluis)

#8707: Add new Lint/ConstantDefinitionInBlock cop. ([@eugeneius][])

Bug fixes

#8627: Fix a false positive for Lint/DuplicateRequire when same feature argument but different require method. (@koic)

#8674: Fix an error for Layout/EmptyLineAfterMultilineCondition when conditional is at the top level. ([@fatkodima][])

#8658: Fix a false positive for Style/RedundantSelfAssignment when calling coercion methods. ([@fatkodima][])

#8669: Fix an offense creation for Lint/EmptyFile. ([@fatkodima][])

#8607: Fix a false positive for Lint/UnreachableLoop when conditional branch includes continue statement preceding break statement. ([@fatkodima][])

#8572: Fix a false positive for Style/RedundantParentheses when parentheses are used like method argument parentheses. (@koic)

#8630: Fix some false positives for Style/HashTransformKeys and Style/HashTransformValues when the receiver is an array. ([@eugeneius][])

#8653: Fix a false positive for Layout/DefEndAlignment when using refinements and private def. (@koic)

#8655: Fix a false positive for Style/ClassAndModuleChildren when using cbase class name. (@koic)

#8654: Fix a false positive for Style/SafeNavigation when checking foo&.empty? in a conditional. (@koic)

#8660: Fix a false positive for Style/ClassAndModuleChildren when using cbase module name. (@koic)

#8664: Fix a false positive for Naming/BinaryOperatorParameterName when naming multibyte character method name. (@koic)

#8604: Fix a false positive for Bundler/DuplicatedGem when gem is duplciated in condition. ([@tejasbubane][])

#8671: Fix an error for Style/ExplicitBlockArgument when using safe navigation method call. (@koic)

#8681: Fix an error for Style/HashAsLastArrayItem with no_braces for empty hash. ([@fsateler][])

#8682: Fix a positive for Style/HashTransformKeys and Style/HashTransformValues when the each_with_object hash is used in the transformed key or value. ([@eugeneius][])

#8688: Mark Style/GlobalStdStream as unsafe autocorrection. ([@marcandre][])

#8642: Fix a false negative for Style/SpaceInsideHashLiteralBraces when a correct empty hash precedes the incorrect hash. (@dvandersluis)

#8683: Make naming cops work with non-ascii characters. ([@tejasbubane][])

#8626: Fix false negatives for Lint/UselessMethodDefinition. ([@marcandre][])

#8698: Fix cache to avoid encoding exception. ([@marcandre][])

#8704: Fix an error for Lint/AmbiguousOperator when using safe navigation operator with a unary operator. (@koic)

#8661: Fix an incorrect auto-correct for Style/MultilineTernaryOperator when returning a multiline ternary operator expression. (@koic)

#8526: Fix a false positive for Style/CaseEquality cop when the receiver is not a camel cased constant. (@koic)

#8673: Fix the JSON parse error when specifying --format=json and --stdin options. (@koic)

Changes

#8470: Do not autocorrect Style/StringConcatenation when parts of the expression are too complex. (@dvandersluis)

#8561: Fix Lint/UselessMethodDefinition to not register an offense when method definition includes optional arguments. ([@fatkodima][])

#8617: Fix Style/HashAsLastArrayItem to not register an offense when all items in an array are hashes. (@dvandersluis)

#8500: Add in? to AllowedMethods for Lint/SafeNavigationChain cop. ([@tejasbubane][])

#8629: Fix the cache being reusable in CI by using crc32 to calculate file hashes rather than mtime, which changes each CI build. (@dvandersluis)

#8663: Fix multiple autocorrection bugs with Style/ClassMethodsDefinitions. (@dvandersluis)

#8621: Add helpful Infinite Loop error message. ([@iSarCasm][])

Changelog

Sourced from rubocop's changelog.

0.91.1 (2020-09-23)

Bug fixes

#8720: Fix an error for Lint/IdentityComparison when calling object_id method without receiver in LHS or RHS. ([@koic][])

#8767: Fix a false positive for Style/RedundantReturn when a rescue has an else clause. ([@fatkodima][])

#8710: Fix a false positive for Layout/RescueEnsureAlignment when Layout/BeginEndAlignment cop is not enabled status. ([@koic][])

#8726: Fix a false positive for Naming/VariableNumber when naming multibyte character variable name. ([@koic][])

#8730: Fix an error for Lint/UselessTimes when there is a blank line in the method definition. ([@koic][])

#8740: Fix a false positive for Style/HashAsLastArrayItem when the hash is in an implicit array. ([@dvandersluis][])

#8739: Fix an error for Lint/UselessTimes when using empty block argument. ([@koic][])

#8742: Fix some assignment counts for Metrics/AbcSize. ([@marcandre][])

#8750: Fix an incorrect auto-correct for Style/MultilineWhenThen when line break for multiple condidate values of when statement. ([@koic][])

#8754: Fix an error for Style/RandomWithOffset when using a range with non-integer bounds. ([@eugeneius][])

#8756: Fix an infinite loop error for Layout/EmptyLinesAroundAccessModifier with Layout/EmptyLinesAroundBlockBody when using access modifier with block argument. ([@koic][])

#8372: Fix Lint/RedundantCopEnableDirective autocorrection to not leave orphaned empty # rubocop:enable comments. ([@dvandersluis][])

#8372: Fix Lint/RedundantCopDisableDirective autocorrection. ([@dvandersluis][])

#8764: Fix Layout/CaseIndentation not showing the cop name in output messages. ([@dvandersluis][])

#8771: Fix an error for Style/OneLineConditional when using if-then-elsif-then-end. ([@koic][])

#8576: Fix Style/IfUnlessModifier to ignore cop disable comment directives when considering conversion to the modifier form. ([@dsavochkin][])

Changes

#8489: Exclude method respond_to_missing? from OptionalBooleanParameter cop. ([@em-gazelle][])

#7914: Style/SafeNavigation marked as having unsafe auto-correction. ([@marcandre][])

#8749: Disable Style/IpAddresses by default in Gemfile and gemspec files. ([@dvandersluis][])

0.91.0 (2020-09-15)

New features

New option --cache-root and support for the RUBOCOP_CACHE_ROOT environment variable. Both can be used to override the AllCops: CacheRootDirectory config, especially in a CI setting. ([@sascha-wolf][])

#8582: Add new Layout/BeginEndAlignment cop. ([@koic][])

#8699: Add new Lint/IdentityComparison cop. ([@koic][])

Add new Lint/UselessTimes cop. ([@dvandersluis][])

#8707: Add new Lint/ConstantDefinitionInBlock cop. ([@eugeneius][])

Bug fixes

#8627: Fix a false positive for Lint/DuplicateRequire when same feature argument but different require method. ([@koic][])

#8674: Fix an error for Layout/EmptyLineAfterMultilineCondition when conditional is at the top level. ([@fatkodima][])

#8658: Fix a false positive for Style/RedundantSelfAssignment when calling coercion methods. ([@fatkodima][])

#8669: Fix an offense creation for Lint/EmptyFile. ([@fatkodima][])

#8607: Fix a false positive for Lint/UnreachableLoop when conditional branch includes continue statement preceding break statement. ([@fatkodima][])

#8572: Fix a false positive for Style/RedundantParentheses when parentheses are used like method argument parentheses. ([@koic][])

#8630: Fix some false positives for Style/HashTransformKeys and Style/HashTransformValues when the receiver is an array. ([@eugeneius][])

#8653: Fix a false positive for Layout/DefEndAlignment when using refinements and private def. ([@koic][])

#8655: Fix a false positive for Style/ClassAndModuleChildren when using cbase class name. ([@koic][])

#8654: Fix a false positive for Style/SafeNavigation when checking foo&.empty? in a conditional. ([@koic][])

#8660: Fix a false positive for Style/ClassAndModuleChildren when using cbase module name. ([@koic][])

Commits

de054ee Cut 0.91.1
c21be8f [Fix #8372] Fix Lint/RedundantCopEnableDirective autocorrection not removin...
b59c48a [Fix #8372] Fix Lint/RedundantCopDisableDirective autocorrection removing a...
39f0624 Move a changelog entry
54c63cf [Fix #8576] Fix Style/IfUnlessModifier to ignore cop disable comment direct...
3ec3e38 Tweak a couple of changelog entries
5cc162e [Fix #8771] Fix an error for Style/OneLineConditional
faaa683 Merge pull request #8769 from koic/use_cop_base_api_for_several_style_cops
c70badc Merge pull request #8768 from fatkodima/redundant_return-rescue-else
fd6d273 Use Cop::Base API for some Style cops
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
@dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

Update frequency (including time of day and day of week)
Pull request limits (per update run and/or open at any time)
Out-of-range updates (receive only lockfile updates, if desired)
Security updates (receive only security updates, if desired)

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.91.1. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.86.0...v0.91.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

dependabot-preview · 2020-09-25T10:15:29Z

Superseded by #153.

dependabot-preview bot added the dependencies Pull requests that update a dependency file label Sep 23, 2020

dependabot-preview bot mentioned this pull request Sep 23, 2020

Bump rubocop from 0.86.0 to 0.91.0 #149

Closed

dependabot-preview bot closed this Sep 25, 2020

dependabot-preview bot deleted the dependabot/bundler/rubocop-0.91.1 branch September 25, 2020 10:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump rubocop from 0.86.0 to 0.91.1 #152

Bump rubocop from 0.86.0 to 0.91.1 #152

Uh oh!

dependabot-preview bot commented Sep 23, 2020

Uh oh!

dependabot-preview bot commented Sep 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Bump rubocop from 0.86.0 to 0.91.1 #152

Bump rubocop from 0.86.0 to 0.91.1 #152

Uh oh!

Conversation

dependabot-preview bot commented Sep 23, 2020

RuboCop 0.91

New features

Bug fixes

Changes

0.91.1 (2020-09-23)

Bug fixes

Changes

0.91.0 (2020-09-15)

New features

Bug fixes

Uh oh!

dependabot-preview bot commented Sep 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant