Merged
Conversation
Contributor
Author
|
@bzaczynski looks like ruff and/or black changed their rules. Should we run an update formatting pass for a new ground truth? That would introduce some discrepancies with tutorial code, but we have some formatting-related one anyways (e.g. newlines after class definitions). Or, otherwise, we'd need to make sure our local linters are pinned to the same versions as these ones. Philipp just bumped into this and the CI error messages are somewhat opaque. What do you think? Did you or Geir Arne do such a style update pass previously that you know of? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where to put new files:
my-awesome-articleHow to merge your changes: