Merged
Conversation
stephengruppetta
requested changes
Jul 4, 2025
Contributor
stephengruppetta
left a comment
There was a problem hiding this comment.
@eyrei123, just a couple of minor comments on the materials repo. Note, I changed the title of the PR and used the keyphrase instead. It's best to make the PR titles descriptive to demostrate which article they belong to
|
|
||
| # 4. Display the exams students have sat five or more times. | ||
|
|
||
| grades.dropna(axis=0, thresh=6) # Remember there are seven columns. |
Contributor
There was a problem hiding this comment.
I went for this:
grades.dropna(thresh=5, subset=grades.columns[1:])
but yours is simpler!
Contributor
Author
There was a problem hiding this comment.
My mind is simpler, remember. :-)
| @@ -0,0 +1,25 @@ | |||
| import pandas as pd | |||
Contributor
There was a problem hiding this comment.
perhaps best to put an underscore in the script name to match the others (and for best practice)
stephengruppetta
approved these changes
Aug 1, 2025
stephengruppetta
approved these changes
Aug 1, 2025
brendaweles
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where to put new files:
my-awesome-articleHow to merge your changes: