Fix statement_position for guard else without whitespace#6543
Open
theamodhshetty wants to merge 1 commit intorealm:mainfrom
Open
Fix statement_position for guard else without whitespace#6543theamodhshetty wants to merge 1 commit intorealm:mainfrom
theamodhshetty wants to merge 1 commit intorealm:mainfrom
Conversation
Open
2 tasks
Generated by 🚫 Danger |
Open
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
guard foo()elseinstatement_positionguard foo() elseThe rule currently only looks for
elseandcatchafter a closing brace, so theguardform from #6153 slips through. This keeps the existing brace-based matching in place and adds a small guard-specific matcher that only fires whenelseis tokenized as a keyword.Testing
swift test --filter StatementPositionRuleGeneratedTestsswift test --filter StatementPositionRuleTests./.build/debug/swiftlint lint Source/SwiftLintBuiltInRules/Rules/Style/StatementPositionRule.swift CHANGELOG.md --strict