fix(indentation_width): catch under-indented closing braces#6524
Open
theamodhshetty wants to merge 3 commits intorealm:mainfrom
Open
fix(indentation_width): catch under-indented closing braces#6524theamodhshetty wants to merge 3 commits intorealm:mainfrom
theamodhshetty wants to merge 3 commits intorealm:mainfrom
Conversation
2 tasks
Generated by 🚫 Danger |
Contributor
Author
|
Pushed a small follow-up in The initial failure was local to the rule file itself ( Re-run checks I used locally:
|
| return [ | ||
| validateClosingDelimiterLine( | ||
| indentation: indentation, | ||
| previousIndentation: previousLineIndentations.last!, |
There was a problem hiding this comment.
Lets try to avoid force unwrapping, in previousIndentation: previousLineIndentations.last!,
Contributor
Author
There was a problem hiding this comment.
You are right. I removed the force unwrap and switched that branch to bind previousLineIndentations.last explicitly in d1f37d5. I reran the focused lint check and swift test --filter IndentationWidthRuleTests locally as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6498
This updates
indentation_widthso lines that start with closing delimiters are validated against the immediately preceding indentation level instead of any earlier indentation on the grid. That catches the under-indented inner}from the report without cascading a second warning onto the next outer closing brace.I also added a regression test for the SwiftUI /
.onTapGestureexample from the issue and a changelog entry for the behavior change.Tests:
swift test --filter IndentationWidthRuleTests