Jinyougnchoi95 working #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chance0523
requested changes
Jul 23, 2021
Contributor
jinyoungchoi95
left a comment
jinyoungchoi95
left a comment
There was a problem hiding this comment.
뭐 이러ㄴㅇ러ㅏㅣ넝ㄹ하셨네요
이런건 이렇게 바꾸는게 좋지않을까요?
나머지는 좋은 것같습니다
DolphaGo
reviewed
Jul 23, 2021
Comment on lines
+15
to
+16
| - 추가 변경해야할 것 | ||
| - A 기능이 동작이 좀 이상해보입니다. 수정하려구 해요. |
Member
There was a problem hiding this comment.
네, 리뷰해주신 내용을 반영하다보니, 이러한 방식이 떠올라서 적용해봤습니다.
의견 부탁드립니다 ^^
Contributor
jinyoungchoi95
left a comment
jinyoungchoi95
left a comment
There was a problem hiding this comment.
이번에는 개발을 잘하셨네요
몇가지 코멘트 질문할 사항 남깁니다
jinyoungchoi95
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[작업 내역]