[READWISE] Fix migration crash with multiple old collection meta entries#20
Open
artemlitch wants to merge 1 commit intoreadwise-rxdb15from
Open
[READWISE] Fix migration crash with multiple old collection meta entries#20artemlitch wants to merge 1 commit intoreadwise-rxdb15from
artemlitch wants to merge 1 commit intoreadwise-rxdb15from
Conversation
artemlitch
force-pushed
the
fix/migration-multiple-old-collection-meta
branch
from
697c3cf to
95ab4d6
Compare
Port upstream fix for getOldCollectionMeta: instead of throwing "more than one old collection meta found" when multiple previous-version metadata entries exist (from an interrupted migration), pick the oldest one so all migration strategies run in sequence. Keeps the original return type (no undefined) to minimize surface area. Upstream ref: https://github.com/pubkey/rxdb/blob/master/src/plugins/migration-schema/migration-helpers.ts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
artemlitch
force-pushed
the
fix/migration-multiple-old-collection-meta
branch
from
95ab4d6 to
3871ad7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port upstream RxDB fix for
getOldCollectionMeta: instead of throwing"more than one old collection meta found"when multiple previous-version metadata entries exist (from an interrupted migration), pick the oldest one so all migration strategies run in sequence.The problem
When a schema migration is interrupted (e.g. app killed mid-migration), the old collection metadata is never cleaned up. On the next schema bump,
getOldCollectionMeta()finds multiple entries and throws — blocking the app forever.The fix
Upstream RxDB already solved this. Instead of throwing, iterate
collectionDocKeys(ordered oldest to newest) and return the first match. This ensures migration starts from the oldest data and chains through all strategies.3 source files changed, everything else is rebuild artifacts.
Upstream ref: https://github.com/pubkey/rxdb/blob/master/src/plugins/migration-schema/migration-helpers.ts