Add Android no-op stub for preventUniversalLinks#12
Merged
artemlitch merged 1 commit intomasterfrom May 8, 2026
Merged
Conversation
Commit 588534c added preventUniversalLinks to the codegen spec (src/RNCWebViewNativeComponent.ts) but only implemented iOS. Codegen generates a single Java interface for all platforms, so Android fails to compile (RNCWebViewManager is not abstract and does not override setPreventUniversalLinks) without a stub. Mirrors b3919a9. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #10 added
preventUniversalLinksto the codegen spec (src/RNCWebViewNativeComponent.ts) with iOS-only implementation. RN codegen emits a singleRNCWebViewManagerInterfacefor both platforms, so Android fails to compile:This adds a no-op stub in the newarch Android manager, mirroring the existing pattern (b3919a9:
setBounces,setLimitsNavigationsToAppBoundDomains,setTintColor,setScrollsToTop,setDragInteractionEnabled).Test plan
:react-native-webview:compileReleaseJavaWithJavac🤖 Generated with Claude Code