fix(mdxish): stop lone leading dash from becoming list in magic block cells#1496
Open
maximilianfalco wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What does this PR do?
Magic block table cells (e.g.
[block:parameters]) that contained a lone leading-,*, or+followed by a space were being parsed by the cell content parser as a bullet list, producing an empty<ul><li>instead of the literal text the author wrote.The fix escapes leading list markers in
parseTableCellbefore handing the cell text to the content parser, so the markers render as plain text while emphasis (*foo*, where the marker hugs the text with no trailing space) still parses correctly.🧪 QA tips
the cells containing
-only should be rendered as plain text instead of an empty list node📸 Screenshot or Loom