fix(mdxish): normalize spacing for blank-line-split table tags#1493
Open
eaglethrost wants to merge 4 commits into
Open
fix(mdxish): normalize spacing for blank-line-split table tags#1493eaglethrost wants to merge 4 commits into
eaglethrost wants to merge 4 commits into
Conversation
kevinports
approved these changes
May 28, 2026
Co-authored-by: Kevin Ports <kevin.ports@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What does this PR do?
Fixes a case where
<Table>cells that contains HTML tags where the opener & closer tags are not alone in their lines and have text before them.Note: the root cause isn't what the ticket describes (HTML whitespace entities on tag lines). It's our
normalizeTagSpacingsymmetry check, when opener and closer are both attached to text but a blank line splits them into separate paragraphs, mdxjs can't match the pair. We now treat that case as needing normalization too.🧪 QA tips
__tests__/transformers/mdxish-tables.test.ts— a<Table>with a<div>whose contents span a blank line now parses to a single table node.