Add default WhenActivated calls to WPF base classes #4277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced parameterless constructors in ReactivePage, ReactiveUserControl, and ReactiveWindow that call WhenActivated with a no-op. This ensures that IActivatableViewModel logic in the ViewModel is triggered when the view is activated, improving consistency and activation handling in WPF views.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
update
What is the current behavior?
A IActivatableViewModel ViewModel would not trigger any events unless WhenActivated exists in the View
What is the new behavior?
Introduced parameterless constructors in ReactivePage, ReactiveUserControl, and ReactiveWindow that call WhenActivated with a no-op. This ensures that IActivatableViewModel logic in the ViewModel is triggered when the view is activated, improving consistency and activation handling in WPF views.
What might this PR break?
If no WhenActivated has been created then the current code would not execute, from now on it would be triggered correctly.
Please check if the PR fulfills these requirements
Other information: