Fix link event to reference currentTarget#49
Merged
Archmonger merged 3 commits intoreactive-python:mainfrom Jan 7, 2025
Merged
Fix link event to reference currentTarget#49Archmonger merged 3 commits intoreactive-python:mainfrom
Archmonger merged 3 commits intoreactive-python:mainfrom
Conversation
Archmonger
approved these changes
Jan 6, 2025
Contributor
|
This needs a quick changelog entry before merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line bug fix, the required href attribute is hanging off event.currentTarget not event.target. If the link has children (icons, spans etc) then event.target will reference one of the children.
Cheers.
By submitting this pull request I agree that all contributions comply with this project's open source license(s).