Use ReactDOM.createRoot instead of ReactDOM.render#238
Closed
ZeroIntensity wants to merge 6 commits intoreactive-python:mainfrom
Closed
Use ReactDOM.createRoot instead of ReactDOM.render#238ZeroIntensity wants to merge 6 commits intoreactive-python:mainfrom
ReactDOM.createRoot instead of ReactDOM.render#238ZeroIntensity wants to merge 6 commits intoreactive-python:mainfrom
Conversation
Contributor
|
Looks like this change broke the testing suite. Maybe the ReactJS version needs to be bumped to support this? |
Author
|
Could be, but looking at the package lock, it seems to be in React 17, so it should support this. I'm not sure how the testing suite it set up, but |
Author
|
Scratch that - |
4 tasks
Contributor
|
Closing in favor of #285 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ReactDOM.renderis deprecated as of React 18 (see here), and removed in React 19 (see here). This switches to the alternative,ReactDOM.createRoot(...).render(<Root />).Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).