[WIP] App startup steady ping after bundles loaded#203
Closed
vzaidman wants to merge 3 commits into
Closed
Conversation
vzaidman
force-pushed
the
app-startup-steady-ping-after-bundles-loaded
branch
8 times, most recently
from
9a5af6d to
6a18930
Compare
vzaidman
force-pushed
the
app-startup-steady-ping-after-bundles-loaded
branch
from
6a18930 to
67572ef
Compare
huntie
reviewed
Sep 1, 2025
| // https://github.com/facebook/hermes/blob/ae235193b9329867afaa2838183cbffa34aca098/API/hermes/cdp/DebuggerDomainAgent.cpp#L183-L185 | ||
| // It measures the round trip time for CDP message after being queued in the CDP queue in each direction. | ||
| await debuggerModel.syncDebuggerId(); | ||
| const roundtripTime = Date.now() - startMs; |
| } | ||
| } | ||
|
|
||
| tryReportingCdpLowRoundtrip(cdpLowRoundtripStartTime: number): boolean { |
Member
There was a problem hiding this comment.
I'm not sure about the "low roundtrip" naming — not quite descriptive enough.
Maybe
tryReportAchievedResponsiveRoundtrip(startTime: number)tryReportBackendRoundtripPerfSettledtryReportStartupLivenessPingSettled(probably best?)tryReportStartupPingSettled
Member
There was a problem hiding this comment.
And, let's add a doc comment above this method to describe how we define/measure this metric.
|
|
||
| import nodeIconStyles from './nodeIcon.css.js'; | ||
|
|
||
| const MS_BETWEEN_ROUNDTRIP_MEASUREMENTS = 3000; |
Member
There was a problem hiding this comment.
Curious if this should be more frequent, as (IIUC) this will create a very coarse, 3s incremented, metric? What about 1s/500ms?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Upstreaming plan
devtools-frontendrepo following the contribution guide for Meta employees OR contribution guide.