Track Stack Trace Frames Succeed / Fail to Resolve URL#191
Merged
Conversation
hoxyq
approved these changes
Jul 10, 2025
hoxyq
left a comment
There was a problem hiding this comment.
- Could you try using data attributes for querying DOM element?
- Can you double-check if this records an event if user console.log's a link, like http://example.com?
4f52f5a to
632fb1d
Compare
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Corresponding PR: D77997371
Context
When a URL for stack trace frames is being resolved for the console UI representation of it:
Success
If a known bundle URL is matched for the frame, it is resolved to link to that URL in the sources panel.
Failure
If the url is unknown, we fallback to just hyperlinking to that unknown url.

Summary
This PR will track for each stack trace if it was managed to resolve all stack trace frames or did it have a set of URLs that were failed to be resolved.
Technical Context
While there are cleaner ways that than using
querySelectorAllto achieve this. None of them were more convenient in terms of branching from CDT.The problem is that the whole process of linkifying frames in the console UI is a "fire and forget" process which means it does not return any results to the initiator at the moment.
When I tried to return any results I found myself changing too many functions in too many files which is bad for a branch that we need to keep up to date with CDT.
Test plan
D77997371
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.