Skip to content

Update README.md#190

Merged
hoxyq merged 1 commit into
mainfrom
sbuggay-patch-1
Jul 11, 2025
Merged

Update README.md#190
hoxyq merged 1 commit into
mainfrom
sbuggay-patch-1

Conversation

@sbuggay
Copy link
Copy Markdown

@sbuggay sbuggay commented Jul 7, 2025

I had to run npm run prebuild to setup build.ninja in out/Default. Without it I wasn't able to run any of the other build options.

Summary

Following the readme, I was running into this error

ninja: Entering directory `/Users/devanb/github/rn-chrome-devtools-frontend__workspace/rn-chrome-devtools-frontend/out/Default'
ninja: error: loading 'build.ninja': No such file or directory

After running prebuild, out/Default was setup correctly. Adding that step to the readme.

Test plan

Fresh clone

source setup.sh
npm run prebuild
npm run build
  • This change maintains backwards compatibility with previous Local Storage data (if modifying settings, experiments, or other persisted client state).

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@sbuggay sbuggay requested a review from huntie July 7, 2025 20:33
@sbuggay sbuggay requested a review from hoxyq July 7, 2025 20:34
@hoxyq
Copy link
Copy Markdown

hoxyq commented Jul 8, 2025

prebuild should always run before build command, unless user has ignore-scripts setting disabled in their npm config.

These are called hooks and they can run before or after the script, depending on the prefix: pre or post. I am not opposed to adding this to our README, though.

Can you run npm config list -l and check what is the value of ignore-scripts setting? If it is true, then hooks won't be executed by default.

@vzaidman
Copy link
Copy Markdown

vzaidman commented Jul 8, 2025

@hoxyq

I had the same issue when I recently installed the repo as well. I had to spent time figuring the same thing out. I propose merging this change.

I've just noticed that for the last 10 months, ignoring scripts is true for everyone. See https://github.com/facebook/react-native-devtools-frontend/blob/main/.npmrc

npm config list -l

shows

; "project" config from /Users/vzaidman/projects/rn-chrome-devtools-frontend__workspace/rn-chrome-devtools-frontend/.npmrc

ignore-scripts = true
include = []
omit = ["optional"]
package-lock = true
prefer-online = true
registry = "https://npm.skia.org/chrome-devtools"
save-dev = true
save-exact = true
save-prefix = ""

; "cli" config from command line options

long = true

@vzaidman vzaidman self-requested a review July 8, 2025 09:38
I had to run `npm run prebuild` to setup `build.ninja` in the out dir. Without it I wasn't able to run any of the other build options.
@hoxyq hoxyq force-pushed the sbuggay-patch-1 branch from e7b9779 to 26fe550 Compare July 11, 2025 12:37
@hoxyq hoxyq merged commit efa49bd into main Jul 11, 2025
5 checks passed
@hoxyq hoxyq deleted the sbuggay-patch-1 branch July 11, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants