refactor: hide console and memory panels / views for profiling builds#163
Conversation
|
Not opposed to hiding stuff that doesn't work yet, but let's talk about the plan to get more of these features working, as I think it's pretty surprising if something as basic as console doesn't work at all. |
It does work. The main reason for hiding Console is to avoid printing this message in a console for profiling builds, because I am about to remove debugger support requirement for Hermes in profiling builds, this should make Hermes even faster and be as close as possible to production in terms of performance. You don't need debugger enabled to get sampling profiler working. Happy to define what's missing for other platforms, will share this internally. |
Summary
For profiling builds, we should be showing only what we explicitly support at the moment: Welcome panel (basically, no-op) and Performance panel.
We should not be showing Memory panel, because it requires debugger support enabled in Hermes and Console, because we currently print a warning message that JavaScript engine was compiled with no debugger support.
I believe we should roll out features (panels) for profiling builds gradually and only once they are properly tested and their support is explicitly stated.
We will also open the drawer view from Welcome panel only for development builds, because it has a Console view. If we just remove the Console view from it, then it will be just an empty drawer opened every time user navigates to Welcome panel.
Test plan
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.