-
Notifications
You must be signed in to change notification settings - Fork 7
Update dependencies (#674) + Support Node 24 LTS (#678) #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates various npm dependencies and reformats markdown tables for better alignment across documentation files.
- Updates multiple development dependencies including Babel packages, testing libraries, build tools, and React dev dependencies
- Reformats markdown tables to improve column alignment and spacing consistency
- Updates peerDependencies for React from 18.2.0 to 18.3.1 in devDependencies
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/docs/getting-started/browsers-and-devices.md | Adjusted spacing in browser compatibility tables for better alignment |
| src/docs/customize/theming/forms.md | Reformatted custom property tables with improved column alignment |
| src/components/Toggle/README.md | Realigned custom property table columns for consistency |
| src/components/SelectField/README.md | Reformatted theming options table with consistent spacing |
| src/components/Radio/README.md | Adjusted custom property table column widths |
| src/components/FormLayout/README.md | Improved alignment in theming and custom field tables |
| package.json | Updated 30+ development dependencies to newer versions, including major version bumps for babel-loader, jest, webpack-cli, and sass-loader |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b832f26 to
df3649a
Compare
c7dc223 to
eddafa8
Compare
eddafa8 to
c344e52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 14 out of 272 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Upgrade base version of Node to version 24. Beside version 24, support version 22. Remove support of version 20.
c344e52 to
3250218
Compare
| "runtime": { | ||
| "name": "node", | ||
| "version": "22.x", | ||
| "version": "22.x || 24.x", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, single version worked for matrix testing of both Node 20 and Node 22 (see .github/workflows/build.yml), but it does not work for Node 22 and Node 24. So I must entered both version (and not just latest one) to make it working. But I think this is correct approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mbohal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I diod not tested, but it looks OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 14 out of 272 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I closed this PR as Github CI got stuck as it requested to pass build in Node 20 which was already removed from CI ... Re-opened it as #679 |
The rest should be updated in #575, #675, #676