feat(android): add option to mute speech recognition beep sound #588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where Android plays an audible "beep" sound when speech recognition starts and stops, which can be disruptive for apps that need continuous voice input or a seamless user experience.
Changes
1. Mute Recognition Sound
Added
muteRecognitionSound()andunmuteRecognitionSound()methods that temporarily mute theSTREAM_NOTIFICATIONduring speech recognition:muteRecognitionSound()is called before starting speech recognitionunmuteRecognitionSound()is called when:stopSpeech()onError()onResults()2. Null Safety Fix
Fixed potential null pointer exception in
onResults()by replacing force-unwrap (cd /Users/saumya_bombaysoftwares/Workspace/ReactNative/meal-tracking-app-rn) with a safe null check.Implementation Details
Testing
Tested locally using patch-package with version 3.2.4. The beep sound is successfully muted during speech recognition on Android devices.
Related
This was initially developed as a patch for a React Native app and we wanted to contribute it back to the library.