Restore New Architecture support with react-native >= 0.76 #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed
|
Any plans to merge this PR? |
marcelo-conilho
approved these changes
Jul 2, 2025
|
Hi @camilossantos2809 can you merge and release your PR? Thanks! |
Contributor
Author
Hi! I don't have access to merge and release :) |
|
Maybe @Naturalclar ?... |
Naturalclar
approved these changes
Aug 31, 2025
Member
Naturalclar
left a comment
Naturalclar
left a comment
There was a problem hiding this comment.
sorry for the late review, lgtm!
|
@Naturalclar Thank you very much for the review, can you please merge this PR if possible, I am also waiting for this PR to be merged 😄 |
Naturalclar
merged commit 802451a
into
react-native-progress-view:master
0 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #152, #154
This PR aims to restore Fabric support, enabling the library to build with React Native versions >= 0.76 when the New Architecture is enabled.
To facilitate testing, the
fabric-exampleapp has been upgraded to React Native 0.78.The only unresolved issue is the
progressImageprop, which I couldn’t get to work. Despite this, I believe these updates are still valuable, as developers can use the library with the New Architecture in most common scenarios.I hope this helps the community, and I’m open to further changes if needed.