This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Full ART types extracted from DefinitelyTyped #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steadicat Looks like it is still missing quite a few typings. Notably rotation on Group, strokeJoin on Shape, but I am sure there are more. |
Esemesek
reviewed
Nov 9, 2020
| } | ||
|
|
||
| export class Surface extends React.Component<ARTSurfaceProps> {} | ||
| ////////////////////////////////////////////////////////////////////////// |
Collaborator
There was a problem hiding this comment.
Can we remove this ugly comment? I don't think we need this in declarations.
|
@steadicat ping |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The type definitions in this repo are woefully incomplete. Thankfully, DefinitelyTyped types for RN have full types for ART. This copies over the relevant types from https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts.
Fixes #59.
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)