fix: avoid inline styles to ensure CSP compliancy#49
Open
jaulz wants to merge 3 commits intoreact-component:masterfrom
Open
fix: avoid inline styles to ensure CSP compliancy#49jaulz wants to merge 3 commits intoreact-component:masterfrom
jaulz wants to merge 3 commits intoreact-component:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/calculateNodeHeight.tsx
Outdated
| `${sizingStyle};${HIDDEN_TEXTAREA_STYLE}`, | ||
| ); | ||
| for (const [name, value] of Object.entries({ ...sizingStyle, ...HIDDEN_TEXTAREA_STYLE })) { | ||
| hiddenTextarea.style[name] = value |
Check notice
Code scanning / CodeQL
Semicolon insertion
Author
|
@MadCcc is there any chance to merge this? 😊 |
|
@MadCcc could you please verify an merge this? |
Member
|
We need some test for it. |
|
@jaulz could you please add some tests for it? |
Author
|
@aso1datov I don't have the capacity right now. Feel free to pull my branch and extend it if you need it urgently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix will avoid setting inline styles and instead sets the styles directly on the element which I think should actually be the correct way of doing it. The nice side effect is that it will ensure that the
unsafe-inlineContent Security Policy will be adhered in all circumstances and hence fix this long standing issue: #14