Skip to content

make sure startIndex <= endIndex when measuring visible tabs#454

Open
rinick wants to merge 1 commit intoreact-component:masterfrom
rinick:patch-1
Open

make sure startIndex <= endIndex when measuring visible tabs#454
rinick wants to merge 1 commit intoreact-component:masterfrom
rinick:patch-1

Conversation

@rinick
Copy link
Contributor

@rinick rinick commented Dec 13, 2021

resolves issue: #444

@vercel
Copy link

vercel bot commented Dec 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/tabs/BMMQgGTCGZTXX1EFz44mJfbA5nCx
✅ Preview: https://tabs-git-fork-rinick-patch-1-react-component.vercel.app

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.30%. Comparing base (3aeba5a) to head (7038242).
⚠️ Report is 221 commits behind head on master.

Files with missing lines Patch % Lines
src/hooks/useVisibleRange.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
- Coverage   99.47%   99.30%   -0.18%     
==========================================
  Files          13       13              
  Lines         570      572       +2     
  Branches      143      144       +1     
==========================================
+ Hits          567      568       +1     
- Misses          3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@afc163
Copy link
Member

afc163 commented Feb 16, 2022

Could you add a test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants