Skip to content

Conversation

@isaacvando
Copy link
Contributor

👋 Hello, upgrading this to version 0.15.1 so that the Roc compiler can upgrade also.

build.zig.zon Outdated
Comment on lines 7 to 8
.url = "git+https://github.com/isaacvando/zig-stable-array#3b8b675b32d31d371dbefed9496312c8f3bba98d",
.hash = "stable_array-0.1.0-3ihgvVxbAACET5MoiUn2T5ENunG_da_X3kGbji-f4QTF",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is updated I can update this to the original repo. I opened a PR for it here rdunnington/zig-stable-array#14

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest zig-stable-array is good with 0.15.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!


fn trampoline(userdata: ?*anyopaque, module: *core.ModuleInstance, params: [*]const Val, returns: [*]Val) error{}!void {
const host: *HostFunc = @alignCast(@ptrCast(userdata));
const host: *HostFunc = @ptrCast(@alignCast(userdata));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done by zig fmt

@rdunnington
Copy link
Owner

Hey thanks a bunch! I didn't even have time to finish reading all the patch notes and here's a full upgrade. :P

uses: mlugg/setup-zig@v1
with:
version: 0.14.0
version: 0.15.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might need to be 0.15.0, IIRC the setup-zig script seems to always use the latest point release since they're only bugfixes, so it gets an error when looking for the specific point release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah gotcha good to know. I updated the version in this PR and the one for zig-stable-array.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, still no luck. I can look into it more later

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this was my bad, I guess it should be 0.15.1 after all. The problem is the formatting of zig env changed so mlugg/setup-zig needs to be upgraded to v2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay cool, thanks for fixing

@rdunnington
Copy link
Owner

Merged as part of #86. Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants