-
Notifications
You must be signed in to change notification settings - Fork 7
Upgrade to Zig 0.15.1 #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build.zig.zon
Outdated
| .url = "git+https://github.com/isaacvando/zig-stable-array#3b8b675b32d31d371dbefed9496312c8f3bba98d", | ||
| .hash = "stable_array-0.1.0-3ihgvVxbAACET5MoiUn2T5ENunG_da_X3kGbji-f4QTF", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is updated I can update this to the original repo. I opened a PR for it here rdunnington/zig-stable-array#14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest zig-stable-array is good with 0.15.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
|
|
||
| fn trampoline(userdata: ?*anyopaque, module: *core.ModuleInstance, params: [*]const Val, returns: [*]Val) error{}!void { | ||
| const host: *HostFunc = @alignCast(@ptrCast(userdata)); | ||
| const host: *HostFunc = @ptrCast(@alignCast(userdata)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done by zig fmt
|
Hey thanks a bunch! I didn't even have time to finish reading all the patch notes and here's a full upgrade. :P |
.github/workflows/ci.yml
Outdated
| uses: mlugg/setup-zig@v1 | ||
| with: | ||
| version: 0.14.0 | ||
| version: 0.15.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might need to be 0.15.0, IIRC the setup-zig script seems to always use the latest point release since they're only bugfixes, so it gets an error when looking for the specific point release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotcha good to know. I updated the version in this PR and the one for zig-stable-array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, still no luck. I can look into it more later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this was my bad, I guess it should be 0.15.1 after all. The problem is the formatting of zig env changed so mlugg/setup-zig needs to be upgraded to v2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay cool, thanks for fixing
|
Merged as part of #86. Thanks again :) |
👋 Hello, upgrading this to version 0.15.1 so that the Roc compiler can upgrade also.