Skip to content

Fdm 103 data sorting #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afleischm wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fdm 103 data sorting #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96d53b3
added sorting for result data (option)
afleischm Sep 7, 2022
72fbd39
updated readme
afleischm Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ OPTIONSET_PROVIDERS = [
```

After restarting RDMO, the `Re3DataProvider` should be selectable as a provider option for option sets.

The re3data plugin in RDMO provides the corresponding repositories, but they were not sorted alphabetically. Now there's the code modified to sort repositories alphabetically, which improved the findabilty of a repository.
3 changes: 2 additions & 1 deletion rdmo_re3data/providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from ast import Lambda
Copy link
Copy Markdown
Member

@jochenklar jochenklar Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @afleischm, thanks for the PR, but this is not needed, right?

Copy link
Copy Markdown
Member

@jochenklar jochenklar Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, two years later, I see that I did not know how to use the rewiew function on GitHub back then. My comment was still pending...

import logging
from urllib.parse import urlencode

Expand Down Expand Up @@ -114,5 +115,5 @@ def get_options(self, project, search=None):
'id': repository_node.find('id').text,
'text': repository_node.find('name').text
})

options.sort(key=lambda option: option.get('text'), reverse=False)
return options