RDKB-64265: Removing erouter0 hardcode for reusability for different wan interface#311
Open
rirfha948 wants to merge 1 commit into
Open
RDKB-64265: Removing erouter0 hardcode for reusability for different wan interface#311rirfha948 wants to merge 1 commit into
rirfha948 wants to merge 1 commit into
Conversation
…ferent wan interface Test Procedure: - Build OneStack Image - In Business-mode, Check dibbler server is started and server.conf has prefix-delegation class - In Residential-mode, check whether device behaves as a non-CBR device Risks: None Priority: P1 - [] Is this a User Story (US)? This is a bug ticket - [x] Have all dependent PRs from other components been listed ? - [x] Does the commit message include both the User Story ticket and the Subtask ticket? - [x] Will be all changes related to the User Story squashed and merged in a single commit? - [x] Has the PR been raised only after completing all changes for the User Story (no partial changes)? - [x] Has code development for the User Story been completed? - [x] If yes, has the Gerrit topic or list of all dependent PRs across components (including meta-layer changes) been shared? https://gerrit.teamccp.com/#/c/953000/ - [x] Is there a validation log available in the Jira ticket for verifying builds with the updated generic-srcrev.inc across all platforms?
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request makes small adjustments in the IPv6 firewall implementation, primarily around prefix buffer handling and a minor cleanup.
Changes:
- Remove a duplicate
memset()ofipv6_delegation_prefix. - Increase the local
prefixbuffer size used in routing rules and simplify its initialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2131
to
+2133
| FIREWALL_DEBUG("Entering applyRoutingRules, ipv6_type is %d \n" COMMA type); | ||
| char prefix[64] ; | ||
| memset(prefix,0,sizeof(prefix)); | ||
| char prefix[129]; | ||
| prefix[0] = 0; |
rirfha948
changed the title
snayak002c
requested changes
May 12, 2026
| FIREWALL_DEBUG("Entering applyRoutingRules, ipv6_type is %d \n" COMMA type); | ||
| char prefix[64] ; | ||
| memset(prefix,0,sizeof(prefix)); | ||
| char prefix[129]; |
Contributor
There was a problem hiding this comment.
define a macro , char prefix[BUF_SIZE + 1];
and why memset is removed ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Procedure:
Build OneStack Image
In Business-mode, Check dibbler server is started and server.conf has prefix-delegation class
In Residential-mode, check whether device behaves as a non-CBR device Risks: None Priority: P1
[] Is this a User Story (US)? This is a bug ticket
Have all dependent PRs from other components been listed ?
Does the commit message include both the User Story ticket and the Subtask ticket?
Will be all changes related to the User Story squashed and merged in a single commit?
Has the PR been raised only after completing all changes for the User Story (no partial changes)?
Has code development for the User Story been completed?
If yes, has the Gerrit topic or list of all dependent PRs across components (including meta-layer changes) been shared? https://gerrit.teamccp.com/#/c/953000/
Is there a validation log available in the Jira ticket for verifying builds with the updated generic-srcrev.inc across all platforms?