RDKEMW-12350: Fix uninitialized missing error checks in timeZoneDST fallback path by Copilot · Pull Request #324 · rdkcentral/telemetry

Copilot · 2026-04-10T17:13:28Z

No description provided.

- Validate ftell return: reject -1 (error) and 0 (empty file) - Add malloc NULL check to prevent NULL pointer dereference - Initialize zone buffer to empty string before fscanf - Reset zone after each iteration to catch stale data - Check fscanf return == 1 instead of != EOF to catch format errors and whitespace-only files - Remove impossible 'zone != NULL' check (zone is stack-local pointer to heap memory, never NULL inside the loop) - Don't reset zoneValue to NULL on empty reads (preserve any previously read valid value) Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/45c3e1dc-dc54-4005-8756-3a32aa7fdeef Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

…d, remove redundant reset Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/45c3e1dc-dc54-4005-8756-3a32aa7fdeef Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/0e080027-1be4-41cd-afbc-25283b55d93f Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Copilot

Pull request overview

This PR hardens the timeZoneDST fallback path in getTimezone() so it safely handles unreadable/empty files and allocation failures, aligning with the goal of fixing uninitialized use and missing error checks in that reader.

Changes:

Add handling for ftell() failure (numbytes < 0) and for empty files (numbytes == 0) in the /opt/persistent/timeZoneDST fallback.
Add malloc failure handling and initialize the zone buffer before reading.
Tighten the read loop condition to only process successful fscanf reads (== 1) and ensure resources are freed/closed on all paths.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

yogeswaransky · 2026-04-14T15:54:06Z

@copilot can you address this comment in a separate PR
#324 (comment)

Copilot · 2026-04-14T15:54:15Z

@yogeswaransky I've opened a new pull request, #329, to work on those changes. Once the pull request is ready, I'll request review from you.

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/2b39401a-79a0-4d6a-a81f-523a6997a872 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/7f6ea2d9-36fa-4120-a7dc-e7bfe71e9f8a Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/03d1c8d7-2587-443b-bbe5-50a78ff7f073 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

…o break in getBuildType Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/d94df585-444b-4056-a136-bc1f7415c614 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

RDKEMW-12350: Add unit tests for timeZoneDST fallback path in getTimezone()

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (4)

source/test/xconf-client/xconfclientTest.cpp:864

curl_url() returns a CURLU* that must be released with curl_url_cleanup(). This test currently uses curl_free() on the handle; please switch to curl_url_cleanup(requestURL).

    CURLU* requestURL = curl_url();
    curl_url_set(requestURL, CURLUPART_URL,
                 "https://mockxconf:50050/loguploader/getT2DCMSettings", 0);
    EXPECT_EQ(T2ERROR_FAILURE, appendRequestParams(requestURL));
    curl_free(requestURL);
    requestURL = NULL;

source/test/xconf-client/xconfclientTest.cpp:890

curl_url() returns a CURLU* that must be released with curl_url_cleanup(). This test currently uses curl_free() on the handle; please switch to curl_url_cleanup(requestURL).

    CURLU* requestURL = curl_url();
    curl_url_set(requestURL, CURLUPART_URL,
                 "https://mockxconf:50050/loguploader/getT2DCMSettings", 0);
    EXPECT_EQ(T2ERROR_FAILURE, appendRequestParams(requestURL));
    curl_free(requestURL);
    requestURL = NULL;

source/test/xconf-client/xconfclientTest.cpp:916

curl_url() returns a CURLU* that must be released with curl_url_cleanup(). This test currently uses curl_free() on the handle; please switch to curl_url_cleanup(requestURL).

    CURLU* requestURL = curl_url();
    curl_url_set(requestURL, CURLUPART_URL,
                 "https://mockxconf:50050/loguploader/getT2DCMSettings", 0);
    EXPECT_EQ(T2ERROR_FAILURE, appendRequestParams(requestURL));
    curl_free(requestURL);
    requestURL = NULL;

source/test/xconf-client/xconfclientTest.cpp:953

curl_url() returns a CURLU* that must be released with curl_url_cleanup(). This test currently uses curl_free() on the handle; please switch to curl_url_cleanup(requestURL).

    CURLU* requestURL = curl_url();
    curl_url_set(requestURL, CURLUPART_URL,
                 "https://mockxconf:50050/loguploader/getT2DCMSettings", 0);
    EXPECT_EQ(T2ERROR_SUCCESS, appendRequestParams(requestURL));
    curl_free(requestURL);
    requestURL = NULL;

+            else if (numbytes == 0 || numbytes > 256)
+            {
+                T2Warning("Warning: timeZoneDST file has unexpected size %ld, skipping\n", numbytes);
+                fclose(file);


+    CURLU* requestURL = curl_url();
+    curl_url_set(requestURL, CURLUPART_URL,
+                 "https://mockxconf:50050/loguploader/getT2DCMSettings", 0);
+    EXPECT_EQ(T2ERROR_FAILURE, appendRequestParams(requestURL));
+    curl_free(requestURL);
+    requestURL = NULL;


+ * Preconditions for each test:
+ *   - All getParameterValue calls succeed (6 calls with dummy values).
+ *   - getBuildType succeeds: fopen(DEVICE_PROPERTIES) returns a fake handle, fscanf
+ *     fills "BUILD_TYPE=PROD" and then returns EOF.
+ *   - getTimezone CPU_ARCH read: fopen(DEVICE_PROPERTIES) returns NULL (no CPU_ARCH).
+ *   - getTimezone JSON loop: fopen("/opt/output.json") returns NULL (10 retries fail).
+ * After these preconditions the timeZoneDST fallback is exercised.
+ */


Copilot AI and others added 2 commits April 10, 2026 17:08

Address code review: separate error/empty checks, add size upper boun…

134706c

…d, remove redundant reset Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/45c3e1dc-dc54-4005-8756-3a32aa7fdeef Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Copilot AI assigned Copilot and yogeswaransky Apr 10, 2026

yogeswaransky changed the title ~~Fix uninitialized zone buffer and missing error checks in timeZoneDST fallback path~~ RDKEMW-12350: Fix uninitialized zone buffer and missing error checks in timeZoneDST fallback path Apr 10, 2026

yogeswaransky unassigned Copilot Apr 10, 2026

Copilot AI requested a review from yogeswaransky April 10, 2026 17:19

Remove upper bound check on timeZoneDST file size

5171908

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/0e080027-1be4-41cd-afbc-25283b55d93f Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

yogeswaransky changed the title ~~RDKEMW-12350: Fix uninitialized zone buffer and missing error checks in timeZoneDST fallback path~~ RDKEMW-12350: Fix uninitialized missing error checks in timeZoneDST fallback path Apr 13, 2026

yogeswaransky marked this pull request as ready for review April 13, 2026 08:39

yogeswaransky requested a review from a team as a code owner April 13, 2026 08:39

Copilot AI review requested due to automatic review settings April 13, 2026 08:39

Merge branch 'develop' into copilot/improve-zone-null-checks

f94256c

Copilot started reviewing on behalf of yogeswaransky April 13, 2026 08:39 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

yogeswaransky approved these changes Apr 13, 2026

View reviewed changes

RDKEMW-12350: Update xconfclient.c

1cbe842

Copilot AI review requested due to automatic review settings April 13, 2026 08:59

Copilot started reviewing on behalf of yogeswaransky April 13, 2026 09:00 View session

Copilot AI review requested due to automatic review settings April 13, 2026 12:03

Copilot started reviewing on behalf of yogeswaransky April 13, 2026 12:04 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Comment thread source/xconf-client/xconfclient.c

RDKEMW-12350: Fix missing error checks in timeZoneDST fallback path

c7d368f

Copilot AI review requested due to automatic review settings April 14, 2026 15:16

Copilot started reviewing on behalf of yogeswaransky April 14, 2026 15:17 View session

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread .github/workflows/L1-tests.yml Outdated

Initial plan

aa88d6d

Copilot AI mentioned this pull request Apr 14, 2026

RDKEMW-12350: Add unit tests for timeZoneDST fallback path in getTimezone() #329

Merged

1 task

Copilot AI and others added 7 commits April 14, 2026 16:15

Add unit tests for timeZoneDST fallback path in getTimezone()

0ceb491

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/2b39401a-79a0-4d6a-a81f-523a6997a872 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Revert build infrastructure changes, keep only test and source changes

46f82cd

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/7f6ea2d9-36fa-4120-a7dc-e7bfe71e9f8a Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Update L1-tests.yml

d10e308

Fix unqualified Invoke in getTimezone_timeZoneDST_valid_timezone test

e9e1117

Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/03d1c8d7-2587-443b-bbe5-50a78ff7f073 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

Fix SetupReachTimeZoneDSTFallback: fscanf called once not twice due t…

0bbe815

…o break in getBuildType Agent-Logs-Url: https://github.com/rdkcentral/telemetry/sessions/d94df585-444b-4056-a136-bc1f7415c614 Co-authored-by: yogeswaransky <166126056+yogeswaransky@users.noreply.github.com>

L1 testcase addition

25ceb4f

RDKEMW-12350: Add unit tests for timeZoneDST fallback path in getTimezone()

Update L1-tests.yml

6f6777f

Copilot AI review requested due to automatic review settings April 16, 2026 10:02

Copilot AI reviewed Apr 16, 2026

View reviewed changes

Comment thread source/test/xconf-client/xconfclientTest.cpp

Comment thread source/test/xconf-client/xconfclientTest.cpp

Comment thread source/xconf-client/xconfclient.c

Comment thread source/test/xconf-client/xconfclientTest.cpp

yogeswaransky and others added 2 commits May 6, 2026 14:11

Merge branch 'develop' into copilot/improve-zone-null-checks

246582a

Merge branch 'develop' into copilot/improve-zone-null-checks

9974cad

Copilot AI review requested due to automatic review settings May 8, 2026 20:24

Copilot started reviewing on behalf of shibu-kv May 8, 2026 20:25 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread source/test/xconf-client/xconfclientTest.cpp

yogeswaransky added 2 commits May 16, 2026 19:58

Merge branch 'develop' into copilot/improve-zone-null-checks

557ea4e

Merge branch 'develop' into copilot/improve-zone-null-checks

9b10eb9

Copilot AI review requested due to automatic review settings May 21, 2026 13:13

Copilot started reviewing on behalf of yogeswaransky May 21, 2026 13:14 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDKEMW-12350: Fix uninitialized missing error checks in timeZoneDST fallback path#324

RDKEMW-12350: Fix uninitialized missing error checks in timeZoneDST fallback path#324
Copilot wants to merge 20 commits into
developfrom
copilot/improve-zone-null-checks

Copilot AI commented Apr 10, 2026 •

edited by yogeswaransky

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

yogeswaransky commented Apr 14, 2026

Uh oh!

Copilot AI commented Apr 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Apr 10, 2026 • edited by yogeswaransky Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

yogeswaransky commented Apr 14, 2026

Uh oh!

Copilot AI commented Apr 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 10, 2026 •

edited by yogeswaransky

Loading