RDKCOM-5420: TELEMETRY-2 Dynamic telemetry markers for Dynamic Tables in Telemetry #161

onkar-panchare1 · 2025-08-28T12:02:17Z

Description:
Introduced marker type DataModelTable for dynamic tables in telemetry.

Enhanced T2 agent to resolve and collect data from all instances of multi-instance object tables when dynamic markers are configured.

Added logic to parse DataModelTable, filter markers based on telemetry profile configuration, and encode them in telemetry reports after collection, ensuring telemetry reports include per-instance data for configured dynamic markers.

Added support for an "index" parameter in configuration to restrict data collection to specific indexes if required.

Reason for change:
Enable telemetry to capture dynamic, per-instance data from tables (e.g., Host table, Wi-Fi associated devices) where indexes are not fixed, ensuring richer and more flexible telemetry collection.

CLAassistant · 2025-08-28T12:02:23Z

All committers have signed the CLA.

onkar-panchare1 · 2025-08-29T05:36:57Z

@shibu-kv Kindly help with more details on coverity scan failed

shibu-kv · 2025-08-29T18:35:46Z

@onkar-panchare1 Thank you for the contribution.
Could you please help with incorporating below suggestions :
1] The report profile schemas are available in the repo here - https://github.com/rdkcentral/telemetry/tree/develop/schemas
Could you please amend the schemas that aligns with the new capabilities supported in the report profile configuration.
2] This project maintains an integration test suite as well in location - https://github.com/rdkcentral/telemetry/tree/develop/test/functional-tests
Could you please help to add tests to add coverage for this new feature addition as well.
3] To maintain a uniform formatting we do enforce a common formatter based on linux utility astyle.
Please format this contribution by running below commands in your fork :
find . -name '.c' -o -name '.h' | xargs astyle --options=.astylerc
find . -name '*.orig' -type f -delete

Formatter configs are already on the project - https://github.com/rdkcentral/telemetry/blob/develop/.astylerc

shibu-kv

Requesting to incorporate few changes outlined ingeneric comments.

onkar-panchare1 · 2025-09-02T07:46:16Z

Requesting to incorporate few changes outlined ingeneric comments.

Hi @shibu-kv
I have updated the MR with uniform formatting and have updated the schema to support new capabilities.
I will be adding tests soon, the MR can be reviewed.

shibu-kv · 2025-09-22T21:25:02Z

Changes looks good. Waiting for the CI workflows results.

rdkcmf-jenkins · 2025-11-02T21:03:10Z

Coverity Issue - Data race condition

Accessing "profile->cachedReportList" without holding lock "_Profile.reuseThreadMutex". Elsewhere, "_Profile.cachedReportList" is written to with "_Profile.reuseThreadMutex" held 5 out of 7 times.

Medium Impact, CWE-366
MISSING_LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
source/bulkdata/profile.c:1449

rdkcmf-jenkins · 2025-11-02T21:03:10Z

Coverity Issue - Data race condition

Accessing "profile->grepSeekProfile->execCounter" without holding lock "plMutex". Elsewhere, "_GrepSeekProfile.execCounter" is written to with "plMutex" held 2 out of 2 times.

Medium Impact, CWE-366
MISSING_LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
source/bulkdata/profile.c:344

source/t2parser/t2parser.c

rdkcmf-jenkins · 2025-11-02T21:03:10Z

source/t2parser/t2parser.c

            T2Debug("%s : reportTimestamp = %d\n", __FUNCTION__, rtformat);
            //CID 337454: Explicit null dereferenced (FORWARD_NULL) ;CID 337448: Explicit null dereferenced (FORWARD_NULL)
-            if (content != NULL && header != NULL)
+            if (content != NULL && header != NULL && index_flag == 0)


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Pointer to local outside scope

Using "header", which points to an out-of-scope variable "basePath".

High Impact, CWE-562
RETURN_LOCAL

source/t2parser/t2parser.c

rdkcmf-jenkins · 2025-11-02T21:40:42Z

Coverity Issue - Use after free

Passing freed pointer "header" as an argument to "T2Log".

High Impact, CWE-416
USE_AFTER_FREE

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
source/t2parser/t2parser.c:1343

source/t2parser/t2parser.c

rdkcmf-jenkins · 2025-11-02T22:17:09Z

source/t2parser/t2parser.c

                T2Debug("[[Added parameter:%s]]\n", header);
            }
+            if (content) {
+                free(content);


Coverity Issue - Free of array-typed value

"free" frees incorrect pointer "content".

High Impact, CWE-590
BAD_FREE

rdkcmf-jenkins · 2025-11-03T09:30:42Z

source/t2parser/t2parser.c

                T2Error("%s Error in adding parameter to profile %s \n", __FUNCTION__, profile->name);
+                if (content)
+                {
+                    free(content);


Coverity Issue - Free of array-typed value

"free" frees incorrect pointer "content".

High Impact, CWE-590
BAD_FREE

Description: Introduced marker type DataModelTable for dynamic tables in telemetry. Enhanced T2 agent to resolve and collect data from all instances of multi-instance object tables when dynamic markers are configured. Added logic to parse DataModelTable, filter markers based on telemetry profile configuration, and encode them in telemetry reports after collection, ensuring telemetry reports include per-instance data for configured dynamic markers. Added support for an "index" parameter in configuration to restrict data collection to specific indexes if required. Reason for change: Enable telemetry to capture dynamic, per-instance data from tables (e.g., Host table, Wi-Fi associated devices) where indexes are not fixed, ensuring richer and more flexible telemetry collection. Signed-off-by: onkar.panchare1 <onkar.panchare@telekom-digital.com>

onkar-panchare1 requested a review from a team August 28, 2025 12:02

onkar-panchare1 force-pushed the develop branch from 189d09f to 84cfa9e Compare August 28, 2025 13:26

onkar-panchare1 force-pushed the develop branch from 84cfa9e to 90aafc3 Compare August 29, 2025 06:00

shibu-kv requested changes Aug 29, 2025

View reviewed changes

onkar-panchare1 force-pushed the develop branch from 90aafc3 to 489d36b Compare September 2, 2025 07:41

onkar-panchare1 force-pushed the develop branch from 489d36b to d129169 Compare September 5, 2025 10:47

onkar-panchare1 requested a review from a team as a code owner September 5, 2025 10:47

pradeeptakdas changed the title ~~TELEMETRY-2: Dynamic telemetry markers for Dynamic Tables in Telemetry~~ RDKCOM-5431: TELEMETRY-2 Dynamic telemetry markers for Dynamic Tables in Telemetry Sep 16, 2025

shibu-kv previously approved these changes Sep 22, 2025

View reviewed changes

pradeeptakdas changed the title ~~RDKCOM-5431: TELEMETRY-2 Dynamic telemetry markers for Dynamic Tables in Telemetry~~ RDKCOM-5420: TELEMETRY-2 Dynamic telemetry markers for Dynamic Tables in Telemetry Sep 23, 2025

onkar-panchare1 dismissed shibu-kv’s stale review via 26090f3 October 6, 2025 01:07

onkar-panchare1 force-pushed the develop branch 2 times, most recently from 26090f3 to 0c74757 Compare October 7, 2025 06:01

onkar-panchare1 force-pushed the develop branch from 0c74757 to 859639c Compare November 2, 2025 20:51

rdkcmf-jenkins reviewed Nov 2, 2025

View reviewed changes

onkar-panchare1 force-pushed the develop branch from 859639c to 1f66006 Compare November 2, 2025 21:27

rdkcmf-jenkins reviewed Nov 2, 2025

View reviewed changes

source/t2parser/t2parser.c Outdated Show resolved Hide resolved

onkar-panchare1 force-pushed the develop branch from 1f66006 to 8bf495f Compare November 2, 2025 22:03

rdkcmf-jenkins reviewed Nov 2, 2025

View reviewed changes

onkar-panchare1 force-pushed the develop branch from 8bf495f to d83f2cf Compare November 3, 2025 09:21

rdkcmf-jenkins reviewed Nov 3, 2025

View reviewed changes

shibu-kv force-pushed the develop branch from d83f2cf to bc5cd6d Compare November 26, 2025 23:41

RDKCOM-5420: TELEMETRY-2 Dynamic telemetry markers for Dynamic Tables in Telemetry #161

Are you sure you want to change the base?

RDKCOM-5420: TELEMETRY-2 Dynamic telemetry markers for Dynamic Tables in Telemetry #161

Uh oh!

Conversation

onkar-panchare1 commented Aug 28, 2025

Uh oh!

CLAassistant commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onkar-panchare1 commented Aug 29, 2025

Uh oh!

shibu-kv commented Aug 29, 2025

Uh oh!

shibu-kv left a comment

Choose a reason for hiding this comment

Uh oh!

onkar-panchare1 commented Sep 2, 2025

Uh oh!

shibu-kv commented Sep 22, 2025

Uh oh!

rdkcmf-jenkins commented Nov 2, 2025

Coverity Issue - Data race condition

Issue location

Uh oh!

rdkcmf-jenkins commented Nov 2, 2025

Coverity Issue - Data race condition

Issue location

Uh oh!

Uh oh!

rdkcmf-jenkins Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Pointer to local outside scope

Uh oh!

Uh oh!

rdkcmf-jenkins commented Nov 2, 2025

Coverity Issue - Use after free

Issue location

Uh oh!

Uh oh!

rdkcmf-jenkins Nov 2, 2025

Choose a reason for hiding this comment

Coverity Issue - Free of array-typed value

Uh oh!

rdkcmf-jenkins Nov 3, 2025

Choose a reason for hiding this comment

Coverity Issue - Free of array-typed value

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Aug 28, 2025 •

edited

Loading

rdkcmf-jenkins Nov 2, 2025 •

edited

Loading