RDKEMW-17726 : Fix RDKV-to-RDKE migration for WPA3#543
Open
jincysam87 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the RDKV-to-RDKE Wi‑Fi migration logic to avoid explicitly setting wifi-sec.key-mgmt, relying on NetworkManager to select the appropriate WPA2/WPA3 security mode based on AP capabilities.
Changes:
- Removed
key_mgmtparsing fromwpa_supplicant.conf(no longer forceswpa-pskvssae). - Switched Wi‑Fi connection setup from
nmcli conn add ... wifi-sec.key-mgmt ...tonmcli device wifi connect ...with optional password.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+112
to
+115
| nmcli device wifi connect ssid "$SSID" | ||
| else | ||
| #connect to wifi | ||
| nmcli conn add type wifi con-name "$SSID" autoconnect yes ifname wlan0 ssid "$SSID" wifi-sec.key-mgmt "$KEY_MGMT" wifi-sec.psk "$PSK" | ||
| nmcli conn reload | ||
| nmcli device wifi connect ssid "$SSID" password "$PSK" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Do not set the security mode. Let NetworkManager detect it based on AP capabilities
Test Procedure: Test migration with WPA2/WPA3 transition/WPA3 mode
Risks: Medium
Signed-off-by: jincysaramma_sam@comcast.com