SERXIONE-8286: subttxrend-app crash with SDK22 #62
Conversation
Reason for change: To address the subtec crash seen in Bcom streambox with RDKE Test Procedure: check for any subtec crash when playing app, subtec sanity tests Priority: P1 Risks: Low Signed-off-by: Tony Paul <Tony_Paul@comcast.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses a crash in the subtec component when running with SDK22 on Bcom streambox with RDKE. The fix attempts to improve EGL display initialization robustness by using the modern eglGetPlatformDisplayEXT API when available, with a fallback to the legacy eglGetDisplay API.
Key Changes:
- Conditionally includes
EGL/eglext.hwhenUSE_UPSTREAM_WAYLANDis defined to access platform-specific EGL extensions - Modifies
initRendering()to attempt usingeglGetPlatformDisplayEXTbefore falling back toeglGetDisplay
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #ifdef USE_UPSTREAM_WAYLAND | ||
| #ifdef EGL_PLATFORM_WAYLAND_EXT | ||
| PFNEGLGETPLATFORMDISPLAYEXTPROC eglGetPlatformDisplayEXT = reinterpret_cast<PFNEGLGETPLATFORMDISPLAYEXTPROC>(eglGetProcAddress("eglGetPlatformDisplayEXT")); | ||
| if (eglGetPlatformDisplayEXT) | ||
| m_eglDisplay = eglGetPlatformDisplayEXT(EGL_PLATFORM_WAYLAND_EXT, getDisplay()->getNativeObject(), nullptr); | ||
| else | ||
| #endif | ||
| #endif | ||
| if (!m_eglDisplay) | ||
| { | ||
| m_eglDisplay = eglGetDisplay(getDisplay()->getNativeObject()); | ||
| } |
There was a problem hiding this comment.
The control flow logic is incorrect due to improper placement of preprocessor directives. When both USE_UPSTREAM_WAYLAND and EGL_PLATFORM_WAYLAND_EXT are defined, the 'else' at line 147 pairs with the 'if' at line 145, making the fallback check at line 150 part of the else clause. This means if eglGetPlatformDisplayEXT is not null but returns EGL_NO_DISPLAY (a valid error case), the fallback to eglGetDisplay will never execute because the else clause is skipped. The 'else' keyword at line 147 should be removed so that line 150's check always runs as an independent fallback, regardless of whether eglGetPlatformDisplayEXT was attempted.
Reason for change: To address the subtec crash seen in Bcom streambox with RDKE
Test Procedure: check for any subtec crash when playing app, subtec sanity tests
Priority: P1
Risks: Low