Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
594597f
Merge pull request #19 from rdkcentral/develop
jincysam87 Apr 23, 2026
712c8e8
Merge branch 'rdkcentral:develop' into develop
jincysam87 Apr 30, 2026
1f5f624
Merge branch 'rdkcentral:develop' into develop
jincysam87 Apr 30, 2026
7a0e1f8
Merge branch 'rdkcentral:develop' into develop
jincysam87 May 7, 2026
1fd41f2
Update NetworkManagerGnomeProxy.cpp
jincysam87 May 7, 2026
3e1b457
Update NetworkManagerGnomeWIFI.cpp
jincysam87 May 7, 2026
e0ed060
Update NetworkManagerGnomeWIFI.h
jincysam87 May 7, 2026
5448555
Update NetworkManagerGnomeWIFI.cpp
jincysam87 May 7, 2026
17d1c07
Update NetworkManagerImplementation.cpp
jincysam87 May 8, 2026
c79bae1
Update NetworkManagerImplementation.cpp
jincysam87 May 8, 2026
bb2d211
Update NetworkManagerImplementation.cpp
jincysam87 May 8, 2026
96e9296
Update NetworkManagerImplementation.cpp
jincysam87 May 8, 2026
3a19acc
Update NetworkManagerGnomeWIFI.cpp
jincysam87 May 8, 2026
ec5d3a2
Potential fix for pull request finding
jincysam87 May 8, 2026
216fb46
Potential fix for pull request finding
jincysam87 May 8, 2026
3aba5bb
Update NetworkManagerGnomeWIFI.cpp
jincysam87 May 8, 2026
7032c46
Update NetworkManagerGnomeWIFI.h
jincysam87 May 8, 2026
712eeba
Update NetworkManagerGnomeWIFI.cpp
jincysam87 May 8, 2026
dbe7119
Update NetworkManagerLibnmTest.cpp
jincysam87 May 8, 2026
9a9ff93
Potential fix for pull request finding
jincysam87 May 8, 2026
b5d5456
Update NetworkManagerGnomeProxy.cpp
jincysam87 May 8, 2026
8b1f241
Update NetworkManagerGnomeWIFI.cpp
jincysam87 May 8, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions plugin/gnome/NetworkManagerGnomeProxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -999,8 +999,15 @@ namespace WPEFramework
string tmpssidlist{};
while (ssids->Next(tmpssidlist) == true)
{
m_filterSsidslist.push_back(tmpssidlist.c_str());
NMLOG_DEBUG("%s added to SSID filtering", tmpssidlist.c_str());
if (!tmpssidlist.empty())
{
m_filterSsidslist.push_back(tmpssidlist.c_str());
NMLOG_DEBUG("%s added to SSID filtering", tmpssidlist.c_str());
}
else
{
NMLOG_DEBUG("Empty SSID encountered in input list; skipping.");
}
}
}

Expand All @@ -1011,7 +1018,7 @@ namespace WPEFramework
}

nmEvent->setwifiScanOptions(true);
if(wifi->wifiScanRequest(m_filterSsidslist.size() == 1 ? m_filterSsidslist[0] : ""))
if(wifi->wifiScanRequest(m_filterSsidslist))
rc = Core::ERROR_NONE;
Comment thread
jincysam87 marked this conversation as resolved.
Comment thread
jincysam87 marked this conversation as resolved.
return rc;
}
Expand Down
16 changes: 9 additions & 7 deletions plugin/gnome/NetworkManagerGnomeWIFI.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1685,7 +1685,7 @@ namespace WPEFramework
g_main_loop_quit(_wifiManager->m_loop);
}

bool wifiManager::wifiScanRequest(std::string ssidReq)
bool wifiManager::wifiScanRequest(const std::vector<std::string>& ssidsToFilter)
{
if(!createClientNewConnection())
return false;
Expand All @@ -1696,23 +1696,25 @@ namespace WPEFramework
return false;
}
m_isSuccess = false;
if(!ssidReq.empty())
if(!ssidsToFilter.empty())
{
Comment thread
jincysam87 marked this conversation as resolved.
NMLOG_INFO("starting wifi scanning .. %s", ssidReq.c_str());
NMLOG_INFO("Starting wifi scanning for %d SSIDs:",static_cast<int>(ssidsToFilter.size()));
GVariantBuilder builder, array_builder;
Comment thread
jincysam87 marked this conversation as resolved.
GVariant *options;
g_variant_builder_init(&builder, G_VARIANT_TYPE_VARDICT);
Comment thread
jincysam87 marked this conversation as resolved.
g_variant_builder_init(&array_builder, G_VARIANT_TYPE("aay"));
g_variant_builder_add(&array_builder, "@ay",
g_variant_new_fixed_array(G_VARIANT_TYPE_BYTE, (const guint8 *) ssidReq.c_str(), ssidReq.length(), 1)
);
for (const auto& ssid : ssidsToFilter) {
g_variant_builder_add(&array_builder, "@ay",
g_variant_new_fixed_array(G_VARIANT_TYPE_BYTE, (const guint8 *) ssid.c_str(), ssid.length(), 1)
);
Comment on lines 1705 to +1709
}
Comment thread
jincysam87 marked this conversation as resolved.
g_variant_builder_add(&builder, "{sv}", "ssids", g_variant_builder_end(&array_builder));
options = g_variant_builder_end(&builder);
nm_device_wifi_request_scan_options_async(wifiDevice, options, m_cancellable, wifiScanCb, this);
g_variant_unref(options); // Unreference the GVariant after passing it to the async function
Comment on lines 1688 to 1714
}
else {
NMLOG_INFO("staring normal wifi scanning ..");
NMLOG_INFO("Starting normal wifi scanning ..");
nm_device_wifi_request_scan_async(wifiDevice, m_cancellable, wifiScanCb, this);
}
wait(m_loop);
Expand Down
3 changes: 2 additions & 1 deletion plugin/gnome/NetworkManagerGnomeWIFI.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include <string.h>
#include <atomic>
#include <mutex>
#include <vector>

#define WPS_RETRY_WAIT_IN_MS 10 // 10 sec
#define WPS_RETRY_COUNT 10
Expand All @@ -54,7 +55,7 @@ namespace WPEFramework
bool activateKnownConnection(std::string iface, std::string knowConnectionID="");
bool wifiConnectedSSIDInfo(Exchange::INetworkManager::WiFiSSIDInfo &ssidinfo);
bool wifiConnect(const Exchange::INetworkManager::WiFiConnectTo &ssidInfo);
Comment thread
jincysam87 marked this conversation as resolved.
bool wifiScanRequest(std::string ssidReq = "");
bool wifiScanRequest(const std::vector<std::string>& ssidsToFilter = {});
Comment thread
jincysam87 marked this conversation as resolved.
bool isWifiScannedRecently(int timelimitInSec = 5); // default 5 sec as shotest scanning interval
Comment thread
jincysam87 marked this conversation as resolved.
bool getKnownSSIDs(std::list<string>& ssids);
bool addToKnownSSIDs(const Exchange::INetworkManager::WiFiConnectTo &ssidinfo);
Expand Down
3 changes: 2 additions & 1 deletion tools/plugincli/NetworkManagerLibnmTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,8 @@ int main()

NMLOG_INFO("Sending WiFi scan request%s", ssid.empty() ? " (all SSIDs)" : (" for SSID: " + ssid).c_str());

if (wifiMgr->wifiScanRequest(ssid)) {
bool scanRequestSent = ssid.empty() ? wifiMgr->wifiScanRequest() : wifiMgr->wifiScanRequest({ssid});
if (scanRequestSent) {
NMLOG_INFO("WiFi scan request sent successfully.");
} else {
NMLOG_ERROR("Failed to send WiFi scan request.");
Expand Down
Loading