Topic/workflows#30
Open
agampa263 wants to merge 9 commits into
Open
Conversation
Signed-off-by: Netaji Panigrahi Netaji_Panigrahi@comcast.com Co-authored-by: Suganya-Sugumar <222150366+Suganya-Sugumar@users.noreply.github.com> Co-authored-by: guruchandru <36739781+guruchandru@users.noreply.github.com> Co-authored-by: Daniel Soden <daniel_soden@comcast.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: sowmiyachelliah <162420027+sowmiyachelliah@users.noreply.github.com> Co-authored-by: Simon Chung <simon.thunderbolt@gmail.com> Co-authored-by: Netaji Panigrahi <114923459+NetajiPanigrahi@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for applying “source patches” to dependency repositories during the dependency setup flow, including a new patch_file patch type handled by shared build utilities.
Changes:
- Introduces
apply_dependency_patches()insetup_dependencies.shand wires it intoprocess_dependency()before header copying/building. - Extends
apply_patch()incommon_build_utils.shwith apatch_filemode that runspatch -p1within the repo.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cov_docker_script/setup_dependencies.sh | Adds per-dependency patch application based on JSON config (source_patches). |
| cov_docker_script/common_build_utils.sh | Implements patch_file patch application logic inside apply_patch(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+142
to
+149
| if [[ "$type" == "patch_file" ]]; then | ||
| # For patch_file type, 'search' parameter contains the patch file path | ||
| local patch_file="$search" | ||
| local repo_dir="$file" | ||
|
|
||
| # Expand environment variables in patch file path | ||
| patch_file=$(eval echo "$patch_file") | ||
|
|
| # For patch_file type, get the patch file path | ||
| patch_file=$(jq -r ".dependencies.repos[$index].source_patches[$i].patch_file" "$CONFIG_FILE") | ||
|
|
||
| # Expand $HOME and $BUILD_DIR in patch file path |
Comment on lines
+159
to
+162
| # Apply the patch using patch -p1 | ||
| if ! patch -p1 < "$patch_file"; then | ||
| err "Failed to apply patch file: $patch_file" | ||
| popd >/dev/null |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.