fix: prevent panic in stakerInfo by passing correct *bind.CallOpts type

[Yashk767]

User description

Description

This PR fixes a runtime panic in the stakerInfo command caused by passing an incorrect argument type to contract binding methods when invoking them via reflection.

The contract bindings expect *bind.CallOpts, but the code was passing bind.CallOpts as a value, resulting in a reflection panic at runtime.

Fixes #1277

How Has This Been Tested?

Reproduced the panic locally using:

razor stakerInfo --stakerId <id>

Verified that the command now completes successfully without panicking and confirmed correct staker information is returned

---

PR Type

Bug fix

---

Description

• Fix runtime panic in GetMaturity by passing pointer to bind.CallOpts

• Contract bindings expect *bind.CallOpts, not value type

• Corrects reflection invocation argument type mismatch

---

Diagram Walkthrough

flowchart LR
  A["GetMaturity function"] -->|"passes opts to InvokeFunctionWithTimeout"| B["InvokeFunctionWithTimeout"]
  B -->|"before: opts value type"| C["❌ Reflection panic"]
  B -->|"after: &opts pointer type"| D["✓ Correct execution"]

Loading

File Walkthrough

	Relevant files
Bug fix	struct-utils.go Pass pointer to bind.CallOpts in GetMaturity                          utils/struct-utils.go Changed opts to &opts in InvokeFunctionWithTimeout call within GetMaturity method Passes pointer to bind.CallOpts instead of value type to match contract binding expectations Fixes runtime panic that occurred when invoking the function via reflection +1/-1

---

[qodo-free-for-open-source-projects]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡	🎫 #1277 🟢 Correct the type mismatch where bind.CallOpts is passed as a value instead of a pointer (*bind.CallOpts) Ensure the contract method invocation via reflection uses the correct pointer type ⚪ Fix the stakerInfo command panic caused by incorrect argument type being passed to contract call The stakerInfo command should execute successfully without panicking when a correct stakerId is provided Return valid staker information after the fix
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[astronaut-aldrin]

Overall Summary 🚀

Houston, we have a successful fix! This PR addresses a critical runtime panic caused by a type mismatch in reflection-based contract calls. The solution is precise and targeted - changing opts to &opts to pass the correct pointer type. Nice catch on this one, astronaut! ✨

General Feedback:

• The fix is solid and directly addresses the root cause identified in issue #1277.
• However, I noticed this pattern appears elsewhere in the codebase. We should audit similar usages to prevent this issue from occurring in other functions.
• Consider adding a note in the code or documentation about the reflection requirement for *bind.CallOpts to help future maintainers.

Specific Code Comments:

File: utils/struct-utils.go - Line: 4 - Code: returnedValues := InvokeFunctionWithTimeout(stakeManager, "Maturities", &opts, big.NewInt(int64(index)))
✨ Perfect fix! Passing &opts instead of opts correctly provides the *bind.CallOpts pointer type that the contract binding expects. This will eliminate the reflection panic. Great debugging work! 🛰️

Critical Observations:

🔥 Important Follow-up Required: I see this same function InvokeFunctionWithTimeout is likely used throughout the codebase with contract bindings. Based on the error pattern, there may be other locations where opts is passed by value instead of by pointer.

💡 Recommendation: Run a codebase-wide search for InvokeFunctionWithTimeout calls to ensure all invocations pass &opts rather than opts. This could be lurking in other commands too!

File: utils/struct-utils.go - Line: 1 - Code: func (s StakeManagerStruct) GetMaturity(client *ethclient.Client, age uint32) (uint16, error) {
💡 Since this was a subtle bug, consider adding a comment above the InvokeFunctionWithTimeout call explaining why the pointer is necessary:

// Note: Must pass &opts (pointer) as contract bindings expect *bind.CallOpts
returnedValues := InvokeFunctionWithTimeout(stakeManager, "Maturities", &opts, big.NewInt(int64(index)))

Reviewed Files:

• utils/struct-utils.go

Positive Notes:

• 🎯 Laser-focused fix that directly addresses the panic without unnecessary changes
• ✅ Proper testing performed to verify the fix works end-to-end
• 📝 Excellent issue documentation with clear reproduction steps and error logs
• 🔍 Good use of debug logging throughout the execution flow

Additional Suggestions:

⚠️ Type Safety Consideration: The use of reflection with InvokeFunctionWithTimeout makes these type mismatches easy to introduce and hard to catch at compile time. Consider:

1. Adding runtime type assertion checks inside InvokeFunctionWithTimeout to provide clearer error messages
2. Or refactoring to use typed function signatures where possible to leverage compile-time type checking

💡 Testing Enhancement: While manual testing is great, consider adding a unit test that specifically exercises this code path to prevent regression. Something like:

func TestGetMaturity_NoReflectionPanic(t *testing.T) {
    // Test that GetMaturity doesn't panic with reflection errors
    // This would have caught the bug before production
}

Mission Status: ✅ CLEARED FOR LAUNCH

This fix is ready to merge! Just keep an eye out for similar patterns elsewhere in the codebase. Safe travels through the cosmos, fellow code explorer! 🌌🚀

---

Review generated by: anthropic/claude-sonnet-4.5

[qodo-free-for-open-source-projects]

PR Code Suggestions ✨

No code suggestions found for the PR.

[astronaut-aldrin]

Overall Summary 🚀

Houston, we have a fix! 🛰️ This PR successfully resolves a critical runtime panic caused by a type mismatch in reflection calls. The change is minimal, surgical, and directly addresses the root cause identified in issue #1277.

General Feedback:

• The fix is spot-on - changing opts to &opts correctly aligns with the contract binding's expectations for *bind.CallOpts. ✨
• Consider auditing other similar patterns in the codebase to prevent this issue from appearing elsewhere.
• The error logs and reproduction steps in the linked issue are excellent for debugging context!

Specific Code Comments:

File: utils/struct-utils.go - Line: 4 - Code: returnedValues := InvokeFunctionWithTimeout(stakeManager, "Maturities", &opts, big.NewInt(int64(index)))
💡 Perfect fix! The address-of operator (&opts) now passes a pointer to bind.CallOpts instead of the value, matching what the generated contract bindings expect via reflection. This prevents the reflect: Call using bind.CallOpts as type *bind.CallOpts panic. Nice catch! 🎯

Reviewed Files:

• utils/struct-utils.go

Critical Observations:

🔥 Consistency Check Required:
While this PR fixes GetMaturity, I'd recommend scanning the entire codebase for similar patterns. Check if other methods in StakeManagerStruct or related structs are passing opts by value instead of by pointer to InvokeFunctionWithTimeout. This could be a systemic issue lurking in other commands.

Suggested search pattern:

InvokeFunctionWithTimeout(.*opts[^&])

⚠️ Testing Coverage:
The manual testing described is great, but consider adding a regression test that:

• Calls GetMaturity programmatically
• Verifies it doesn't panic
• Validates the returned maturity value

This would prevent future refactoring from reintroducing the bug.

Positive Notes:

• Single-line fix for a critical bug - that's efficient engineering! 🛰️
• The PR description is thorough with excellent reproduction steps and a helpful mermaid diagram
• The error message in the panic was clear enough to identify the exact issue - good Go reflection error handling
• The fix aligns perfectly with Go's idiomatic use of pointers for optional parameters (which bind.CallOpts essentially is)

Mission Status: ✅ APPROVED FOR LIFTOFF

This is a clean, targeted bugfix that resolves a runtime crash. The change is correct and necessary. Just make sure to sweep the rest of the codebase for similar issues before declaring full mission success! 🚀✨

---

Review generated by: anthropic/claude-sonnet-4.5